Re: [libvirt] [PATCH 1/3] conf: Reposition adding SCSI controller for SCSI hostdev hotplug

2015-12-03 Thread Boris Fiuczynski
On 12/02/2015 06:13 PM, John Ferlan wrote: On 12/02/2015 11:37 AM, Boris Fiuczynski wrote: [...] So, what if qemuDomainFindOrCreateSCSIDiskController checked the "found" cont in the first loop for "cont->info.alias". If it doesn't exist, then fall through under the "assumption" that the

Re: [libvirt] [PATCH 1/3] conf: Reposition adding SCSI controller for SCSI hostdev hotplug

2015-12-03 Thread Boris Fiuczynski
On 12/03/2015 02:05 PM, Boris Fiuczynski wrote: conf: Revert some code to resolve issues for hostdev hotplug This patch reverts parts of commits 0d8b24f6b and 0785966d dealing with the addition of a controller during virDomainHostdevAssignAddress. This caused a regression for the hostdev

Re: [libvirt] [PATCH 1/3] conf: Reposition adding SCSI controller for SCSI hostdev hotplug

2015-12-03 Thread John Ferlan
On 12/03/2015 08:20 AM, Boris Fiuczynski wrote: > On 12/03/2015 02:05 PM, Boris Fiuczynski wrote: >> conf: Revert some code to resolve issues for hostdev hotplug >> >> This patch reverts parts of commits 0d8b24f6b and 0785966d dealing with >> the addition of a controller during

Re: [libvirt] [PATCH 1/3] conf: Reposition adding SCSI controller for SCSI hostdev hotplug

2015-12-02 Thread John Ferlan
On 12/02/2015 03:27 AM, Boris Fiuczynski wrote: > On 12/02/2015 01:16 AM, John Ferlan wrote: >> >> >> On 11/30/2015 06:05 AM, Boris Fiuczynski wrote: >> >> [...] >> >>> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c >>> index cbfc41e..69cfd0f 100644 >>> --- a/src/conf/domain_conf.c

Re: [libvirt] [PATCH 1/3] conf: Reposition adding SCSI controller for SCSI hostdev hotplug

2015-12-02 Thread Boris Fiuczynski
On 12/02/2015 04:08 PM, John Ferlan wrote: On 12/02/2015 03:27 AM, Boris Fiuczynski wrote: On 12/02/2015 01:16 AM, John Ferlan wrote: On 11/30/2015 06:05 AM, Boris Fiuczynski wrote: [...] diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index cbfc41e..69cfd0f 100644 ---

Re: [libvirt] [PATCH 1/3] conf: Reposition adding SCSI controller for SCSI hostdev hotplug

2015-12-02 Thread John Ferlan
On 12/02/2015 11:37 AM, Boris Fiuczynski wrote: [...] >> So, what if qemuDomainFindOrCreateSCSIDiskController checked the "found" >> cont in the first loop for "cont->info.alias". If it doesn't exist, then >> fall through under the "assumption" that the controller was added by >> some other

Re: [libvirt] [PATCH 1/3] conf: Reposition adding SCSI controller for SCSI hostdev hotplug

2015-12-02 Thread Boris Fiuczynski
On 12/02/2015 01:16 AM, John Ferlan wrote: On 11/30/2015 06:05 AM, Boris Fiuczynski wrote: [...] diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index cbfc41e..69cfd0f 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -16285,6 +16285,9 @@

Re: [libvirt] [PATCH 1/3] conf: Reposition adding SCSI controller for SCSI hostdev hotplug

2015-12-02 Thread Boris Fiuczynski
On 12/01/2015 05:21 PM, John Ferlan wrote: On 11/30/2015 06:05 AM, Boris Fiuczynski wrote: This patch reverts a part of commit 0d8b24f6b. With commits 0d8b24g6 and 0785966d automatically adding a required controller g6 ? I assume you meant f6b... yes had been moved from the domain xml

Re: [libvirt] [PATCH 1/3] conf: Reposition adding SCSI controller for SCSI hostdev hotplug

2015-12-01 Thread John Ferlan
On 11/30/2015 06:05 AM, Boris Fiuczynski wrote: [...] > diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c > index cbfc41e..69cfd0f 100644 > --- a/src/conf/domain_conf.c > +++ b/src/conf/domain_conf.c > @@ -16285,6 +16285,9 @@ virDomainDefParseXML(xmlDocPtr xml, > } > >

Re: [libvirt] [PATCH 1/3] conf: Reposition adding SCSI controller for SCSI hostdev hotplug

2015-12-01 Thread John Ferlan
On 11/30/2015 06:05 AM, Boris Fiuczynski wrote: > This patch reverts a part of commit 0d8b24f6b. > With commits 0d8b24g6 and 0785966d automatically adding a required controller g6 ? I assume you meant f6b... > had been moved from the domain xml parsing code section into the device post > xml

[libvirt] [PATCH 1/3] conf: Reposition adding SCSI controller for SCSI hostdev hotplug

2015-11-30 Thread Boris Fiuczynski
This patch reverts a part of commit 0d8b24f6b. With commits 0d8b24g6 and 0785966d automatically adding a required controller had been moved from the domain xml parsing code section into the device post xml parsing code section and in doing so breaking as a side effect the SCSI hostdev hotplugging