Re: [libvirt] [PATCH 1/3] leasetime support for globally

2017-06-22 Thread Alberto Ruiz
2017-06-22 21:47 GMT+01:00 Laine Stump : > On 06/22/2017 12:21 PM, Alberto Ruiz wrote: >> Hello Laine, >> >> 2017-06-21 17:30 GMT+01:00 Laine Stump > >: >> >> On 06/21/2017 03:27 AM, Peter Krempa wrote: >> > On Tue, Jun 20, 2017 at 19:00:43 +0100, ar...@gnome.org >>

Re: [libvirt] [PATCH 1/3] leasetime support for globally

2017-06-22 Thread Alberto Ruiz
2017-06-22 22:05 GMT+01:00 Laine Stump : > > On 06/22/2017 01:12 PM, Alberto Ruiz wrote: > > > > > > 2017-06-21 17:30 GMT+01:00 Laine Stump > >: > > > > On 06/21/2017 03:27 AM, Peter Krempa wrote: > > > On Tue, Jun 20, 2017 at 19:00:43 +0100, ar...@gnome.org > >

Re: [libvirt] [PATCH 1/3] leasetime support for globally

2017-06-22 Thread Laine Stump
On 06/22/2017 01:12 PM, Alberto Ruiz wrote: > > > 2017-06-21 17:30 GMT+01:00 Laine Stump >: > > On 06/21/2017 03:27 AM, Peter Krempa wrote: > > On Tue, Jun 20, 2017 at 19:00:43 +0100, ar...@gnome.org > wrote: > >> From: Alberto Ruiz

Re: [libvirt] [PATCH 1/3] leasetime support for globally

2017-06-22 Thread Laine Stump
On 06/22/2017 12:21 PM, Alberto Ruiz wrote: > Hello Laine, > > 2017-06-21 17:30 GMT+01:00 Laine Stump >: > > On 06/21/2017 03:27 AM, Peter Krempa wrote: > > On Tue, Jun 20, 2017 at 19:00:43 +0100, ar...@gnome.org > wrote: > >> From: A

Re: [libvirt] [PATCH 1/3] leasetime support for globally

2017-06-22 Thread Alberto Ruiz
2017-06-21 17:30 GMT+01:00 Laine Stump : > On 06/21/2017 03:27 AM, Peter Krempa wrote: > > On Tue, Jun 20, 2017 at 19:00:43 +0100, ar...@gnome.org wrote: > >> From: Alberto Ruiz > > > > Missing commit message. > > And when composing the commit message, it's useful to include links to > the associ

Re: [libvirt] [PATCH 1/3] leasetime support for globally

2017-06-22 Thread Alberto Ruiz
2017-06-21 17:30 GMT+01:00 Laine Stump : > On 06/21/2017 03:27 AM, Peter Krempa wrote: > > On Tue, Jun 20, 2017 at 19:00:43 +0100, ar...@gnome.org wrote: > >> From: Alberto Ruiz > > > > Missing commit message. > > And when composing the commit message, it's useful to include links to > the associ

Re: [libvirt] [PATCH 1/3] leasetime support for globally

2017-06-22 Thread Alberto Ruiz
Hello Laine, 2017-06-21 17:30 GMT+01:00 Laine Stump : > On 06/21/2017 03:27 AM, Peter Krempa wrote: > > On Tue, Jun 20, 2017 at 19:00:43 +0100, ar...@gnome.org wrote: > >> From: Alberto Ruiz > > > > Missing commit message. > > And when composing the commit message, it's useful to include links t

Re: [libvirt] [PATCH 1/3] leasetime support for globally

2017-06-21 Thread Laine Stump
On 06/21/2017 03:27 AM, Peter Krempa wrote: > On Tue, Jun 20, 2017 at 19:00:43 +0100, ar...@gnome.org wrote: >> From: Alberto Ruiz > > Missing commit message. And when composing the commit message, it's useful to include links to the associated BZ. https://bugzilla.redhat.com/show_bug.cgi?id=

Re: [libvirt] [PATCH 1/3] leasetime support for globally

2017-06-21 Thread Alberto Ruiz
Hello Peter, Thanks for the comments, I will update the patch with your feedback, and sorry I thought I rebased it before I sent it, will fix that too. 2017-06-21 8:27 GMT+01:00 Peter Krempa : > On Tue, Jun 20, 2017 at 19:00:43 +0100, ar...@gnome.org wrote: > > From: Alberto Ruiz > > Missing co

Re: [libvirt] [PATCH 1/3] leasetime support for globally

2017-06-21 Thread Peter Krempa
On Tue, Jun 20, 2017 at 19:00:43 +0100, ar...@gnome.org wrote: > From: Alberto Ruiz Missing commit message. > > --- > docs/schemas/basictypes.rng | 16 + > docs/schemas/network.rng | 8 +++ > src/conf/network_conf.c

[libvirt] [PATCH 1/3] leasetime support for globally

2017-06-20 Thread aruiz
From: Alberto Ruiz --- docs/schemas/basictypes.rng | 16 + docs/schemas/network.rng | 8 +++ src/conf/network_conf.c | 78 ++- src/conf/network_conf.h | 3 +- src/network/