Re: [libvirt] [PATCH 1/3] qemu: Allow to specify the sysfs root for qemuBuildCommandLine

2013-05-16 Thread Daniel P. Berrange
On Wed, May 15, 2013 at 01:09:44PM -0400, Laine Stump wrote: On 05/15/2013 07:23 AM, Osier Yang wrote: On 15/05/13 19:09, Daniel P. Berrange wrote: Instead of adding many parameters to the API, we could provide a struct Agreed, many params is always not good. . containing all the

[libvirt] [PATCH 1/3] qemu: Allow to specify the sysfs root for qemuBuildCommandLine

2013-05-15 Thread Osier Yang
Since 0d70656afded, it starts to access the sysfs files to build the qemu command line (by virSCSIDeviceGetSgName, which is find out the scsi generic device name by adpater:bus:target:unit), there is no way to work around, qemu wants to see the scsi generic device like /dev/sg6 anyway. And I

Re: [libvirt] [PATCH 1/3] qemu: Allow to specify the sysfs root for qemuBuildCommandLine

2013-05-15 Thread Daniel P. Berrange
On Wed, May 15, 2013 at 06:52:44PM +0800, Osier Yang wrote: Since 0d70656afded, it starts to access the sysfs files to build the qemu command line (by virSCSIDeviceGetSgName, which is find out the scsi generic device name by adpater:bus:target:unit), there is no way to work around, qemu wants

Re: [libvirt] [PATCH 1/3] qemu: Allow to specify the sysfs root for qemuBuildCommandLine

2013-05-15 Thread Daniel P. Berrange
On Wed, May 15, 2013 at 12:07:42PM +0100, Daniel P. Berrange wrote: On Wed, May 15, 2013 at 06:52:44PM +0800, Osier Yang wrote: Since 0d70656afded, it starts to access the sysfs files to build the qemu command line (by virSCSIDeviceGetSgName, which is find out the scsi generic device name

Re: [libvirt] [PATCH 1/3] qemu: Allow to specify the sysfs root for qemuBuildCommandLine

2013-05-15 Thread Osier Yang
On 15/05/13 19:09, Daniel P. Berrange wrote: On Wed, May 15, 2013 at 12:07:42PM +0100, Daniel P. Berrange wrote: On Wed, May 15, 2013 at 06:52:44PM +0800, Osier Yang wrote: Since 0d70656afded, it starts to access the sysfs files to build the qemu command line (by virSCSIDeviceGetSgName, which

Re: [libvirt] [PATCH 1/3] qemu: Allow to specify the sysfs root for qemuBuildCommandLine

2013-05-15 Thread Guido Günther
On Wed, May 15, 2013 at 06:52:44PM +0800, Osier Yang wrote: Since 0d70656afded, it starts to access the sysfs files to build the qemu command line (by virSCSIDeviceGetSgName, which is find I'm not a native speaker but s/which is/to/ sounds better to me. out the scsi generic device name by

Re: [libvirt] [PATCH 1/3] qemu: Allow to specify the sysfs root for qemuBuildCommandLine

2013-05-15 Thread Osier Yang
On 15/05/13 21:18, Guido Günther wrote: On Wed, May 15, 2013 at 06:52:44PM +0800, Osier Yang wrote: Since 0d70656afded, it starts to access the sysfs files to build the qemu command line (by virSCSIDeviceGetSgName, which is find I'm not a native speaker but s/which is/to/ sounds better to

Re: [libvirt] [PATCH 1/3] qemu: Allow to specify the sysfs root for qemuBuildCommandLine

2013-05-15 Thread Laine Stump
On 05/15/2013 07:23 AM, Osier Yang wrote: On 15/05/13 19:09, Daniel P. Berrange wrote: On Wed, May 15, 2013 at 12:07:42PM +0100, Daniel P. Berrange wrote: On Wed, May 15, 2013 at 06:52:44PM +0800, Osier Yang wrote: Since 0d70656afded, it starts to access the sysfs files to build the qemu

Re: [libvirt] [PATCH 1/3] qemu: Allow to specify the sysfs root for qemuBuildCommandLine

2013-05-15 Thread Osier Yang
On 16/05/13 01:09, Laine Stump wrote: On 05/15/2013 07:23 AM, Osier Yang wrote: On 15/05/13 19:09, Daniel P. Berrange wrote: On Wed, May 15, 2013 at 12:07:42PM +0100, Daniel P. Berrange wrote: On Wed, May 15, 2013 at 06:52:44PM +0800, Osier Yang wrote: Since 0d70656afded, it starts to access