Re: [libvirt] [PATCH 1/3] qemuDomainBuildNamespace: Clean up temp files

2017-06-15 Thread John Ferlan
On 06/15/2017 09:44 AM, Michal Privoznik wrote: > On 06/15/2017 02:03 PM, John Ferlan wrote: >> >> >> On 06/15/2017 04:53 AM, Michal Privoznik wrote: >>> On 06/14/2017 09:50 PM, John Ferlan wrote: On 06/12/2017 11:57 AM, Michal Privoznik wrote: >

Re: [libvirt] [PATCH 1/3] qemuDomainBuildNamespace: Clean up temp files

2017-06-15 Thread Michal Privoznik
On 06/15/2017 02:03 PM, John Ferlan wrote: > > > On 06/15/2017 04:53 AM, Michal Privoznik wrote: >> On 06/14/2017 09:50 PM, John Ferlan wrote: >>> >>> >>> On 06/12/2017 11:57 AM, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1431112 After 290a00e41d we know

Re: [libvirt] [PATCH 1/3] qemuDomainBuildNamespace: Clean up temp files

2017-06-15 Thread John Ferlan
On 06/15/2017 04:53 AM, Michal Privoznik wrote: > On 06/14/2017 09:50 PM, John Ferlan wrote: >> >> >> On 06/12/2017 11:57 AM, Michal Privoznik wrote: >>> https://bugzilla.redhat.com/show_bug.cgi?id=1431112 >>> >>> After 290a00e41d we know how to deal with file mount points. >>> However, when

Re: [libvirt] [PATCH 1/3] qemuDomainBuildNamespace: Clean up temp files

2017-06-15 Thread Michal Privoznik
On 06/14/2017 09:50 PM, John Ferlan wrote: > > > On 06/12/2017 11:57 AM, Michal Privoznik wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1431112 >> >> After 290a00e41d we know how to deal with file mount points. >> However, when cleaning up the temporary location for preserved >> mount

Re: [libvirt] [PATCH 1/3] qemuDomainBuildNamespace: Clean up temp files

2017-06-14 Thread John Ferlan
On 06/12/2017 11:57 AM, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1431112 > > After 290a00e41d we know how to deal with file mount points. > However, when cleaning up the temporary location for preserved > mount points we are still calling rmdir(). This won't fly for

[libvirt] [PATCH 1/3] qemuDomainBuildNamespace: Clean up temp files

2017-06-12 Thread Michal Privoznik
https://bugzilla.redhat.com/show_bug.cgi?id=1431112 After 290a00e41d we know how to deal with file mount points. However, when cleaning up the temporary location for preserved mount points we are still calling rmdir(). This won't fly for files. We need to call unlink(). Now, since we don't really