Re: [libvirt] [PATCH 1/3] qemuProcessStop: Set @def early

2019-11-19 Thread Michal Privoznik
On 11/19/19 10:04 AM, Erik Skultety wrote: On Tue, Nov 19, 2019 at 09:58:42AM +0100, Michal Privoznik wrote: The @def variable holds pointer to the domain defintion, but is set only somewhere in the middle of the function. This is suboptimal. Signed-off-by: Michal Privoznik --- src/qemu/qemu

Re: [libvirt] [PATCH 1/3] qemuProcessStop: Set @def early

2019-11-19 Thread Erik Skultety
On Tue, Nov 19, 2019 at 09:58:42AM +0100, Michal Privoznik wrote: > The @def variable holds pointer to the domain defintion, but is > set only somewhere in the middle of the function. This is > suboptimal. > > Signed-off-by: Michal Privoznik > --- > src/qemu/qemu_process.c | 4 ++-- > 1 file chan

[libvirt] [PATCH 1/3] qemuProcessStop: Set @def early

2019-11-19 Thread Michal Privoznik
The @def variable holds pointer to the domain defintion, but is set only somewhere in the middle of the function. This is suboptimal. Signed-off-by: Michal Privoznik --- src/qemu/qemu_process.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/