Re: [libvirt] [PATCH 1/3] storage: Need to clear pool prior to calling the refreshPool

2016-05-11 Thread John Ferlan
[...] > > While there's nothing wrong with this patch, after it we have this pair > of ClearVols() + refreshPool() occurring all over the place. Should we > create a wrapper function over it so we not miss anything similar in the > future? > I've thrashed that idea around a few times as

Re: [libvirt] [PATCH 1/3] storage: Need to clear pool prior to calling the refreshPool

2016-05-11 Thread Michal Privoznik
On 10.05.2016 15:26, John Ferlan wrote: > Prior to calling the 'refreshPool' during CreatePool or UploadPool > operations, we need to clear the pool; otherwise, the pool will > have duplicated entries. > > Signed-off-by: John Ferlan > --- > src/storage/storage_driver.c | 3

[libvirt] [PATCH 1/3] storage: Need to clear pool prior to calling the refreshPool

2016-05-10 Thread John Ferlan
Prior to calling the 'refreshPool' during CreatePool or UploadPool operations, we need to clear the pool; otherwise, the pool will have duplicated entries. Signed-off-by: John Ferlan --- src/storage/storage_driver.c | 3 +++ 1 file changed, 3 insertions(+) diff --git