Re: [libvirt] [PATCH 1/3] storage: mpath: Clean up some error handling

2010-05-21 Thread Cole Robinson
On 05/20/2010 06:10 PM, Eric Blake wrote: > On 05/20/2010 01:23 PM, Cole Robinson wrote: >> We were squashing error messages in a few cases. Recode to follow common >> ret = -1 convention. > > s/squashing/duplicating/, but I did check that the only caller, > virStorageBackendMpathNewVol does print

Re: [libvirt] [PATCH 1/3] storage: mpath: Clean up some error handling

2010-05-20 Thread Eric Blake
On 05/20/2010 01:23 PM, Cole Robinson wrote: > We were squashing error messages in a few cases. Recode to follow common > ret = -1 convention. s/squashing/duplicating/, but I did check that the only caller, virStorageBackendMpathNewVol does print a message when it gets a negative result. > @@ -43

[libvirt] [PATCH 1/3] storage: mpath: Clean up some error handling

2010-05-20 Thread Cole Robinson
We were squashing error messages in a few cases. Recode to follow common ret = -1 convention. Signed-off-by: Cole Robinson --- src/storage/storage_backend_mpath.c | 20 1 files changed, 4 insertions(+), 16 deletions(-) diff --git a/src/storage/storage_backend_mpath.c b/s