Re: [libvirt] [PATCH 1/3] tests: Turn virFileWrapperAddPrefix to void

2019-03-13 Thread Erik Skultety
On Wed, Mar 13, 2019 at 11:13:07AM +0100, Michal Privoznik wrote: > In theory, it's nice to have virFileWrapperAddPrefix() return a > value that indicates if the function succeeded or not. But in > practice, nobody checks for that and in fact blindly believes > that the function succeeded.

Re: [libvirt] [PATCH 1/3] tests: Turn virFileWrapperAddPrefix to void

2019-03-13 Thread Martin Kletzander
On Wed, Mar 13, 2019 at 11:13:07AM +0100, Michal Privoznik wrote: In theory, it's nice to have virFileWrapperAddPrefix() return a value that indicates if the function succeeded or not. But in practice, nobody checks for that and in fact blindly believes that the function succeeded. Therefore,

[libvirt] [PATCH 1/3] tests: Turn virFileWrapperAddPrefix to void

2019-03-13 Thread Michal Privoznik
In theory, it's nice to have virFileWrapperAddPrefix() return a value that indicates if the function succeeded or not. But in practice, nobody checks for that and in fact blindly believes that the function succeeded. Therefore, make the function return nothing and just abort() if it would fail.