Re: [libvirt] [PATCH 1/3] util: Rework virStringListAdd

2018-07-27 Thread Erik Skultety
On Thu, Jul 26, 2018 at 05:36:27PM +0200, Michal Privoznik wrote: > So every caller does the same: they use virStringListAdd() to add ^This sounds a bit like there's a handful of them ;). > new item into the list and then free the old copy to replace it > with new list. It's not very memory

[libvirt] [PATCH 1/3] util: Rework virStringListAdd

2018-07-26 Thread Michal Privoznik
So every caller does the same: they use virStringListAdd() to add new item into the list and then free the old copy to replace it with new list. It's not very memory effective, nor environmental friendly. Signed-off-by: Michal Privoznik --- src/util/virmacmap.c | 8 ++--