Re: [libvirt] [PATCH 1/3] vsh: Make self-test more robust

2017-11-21 Thread Michal Privoznik
On 11/21/2017 10:25 AM, Erik Skultety wrote: > On Thu, Nov 16, 2017 at 02:49:27PM +0100, Michal Privoznik wrote: >> There are couple of limitations when it comes to option types and >> flags for the options. For instance, VSH_OT_STRING cannot have >> VSH_OFLAG_REQ set (commit c7543a728). For some r

Re: [libvirt] [PATCH 1/3] vsh: Make self-test more robust

2017-11-21 Thread Erik Skultety
On Thu, Nov 16, 2017 at 02:49:27PM +0100, Michal Privoznik wrote: > There are couple of limitations when it comes to option types and > flags for the options. For instance, VSH_OT_STRING cannot have > VSH_OFLAG_REQ set (commit c7543a728). For some reason this is > checked in vshCmddefHelp() but not

[libvirt] [PATCH 1/3] vsh: Make self-test more robust

2017-11-16 Thread Michal Privoznik
There are couple of limitations when it comes to option types and flags for the options. For instance, VSH_OT_STRING cannot have VSH_OFLAG_REQ set (commit c7543a728). For some reason this is checked in vshCmddefHelp() but not in vshCmddefCheckInternals(). Signed-off-by: Michal Privoznik --- tool