Re: [libvirt] [PATCH 1/4] Convert the remote driver to new RPC client APIs

2011-06-28 Thread Daniel P. Berrange
On Mon, Jun 27, 2011 at 02:08:07PM -0600, Eric Blake wrote: On 06/27/2011 08:24 AM, Daniel P. Berrange wrote: This guts the current remote driver, removing all its networking handling code. Instead it calls out to the new virClientPtr and virClientProgramPtr APIs for all RPC networking

Re: [libvirt] [PATCH 1/4] Convert the remote driver to new RPC client APIs

2011-06-28 Thread Daniel P. Berrange
On Mon, Jun 27, 2011 at 02:49:37PM -0600, Eric Blake wrote: On 06/27/2011 02:08 PM, Eric Blake wrote: Aargh, I hit send too soon. +case trans_ext: { +char const *cmd_argv[] = { command, NULL }; +if (!(priv-client = virNetClientNewExternal(cmd_argv))) This appears

Re: [libvirt] [PATCH 1/4] Convert the remote driver to new RPC client APIs

2011-06-28 Thread Daniel P. Berrange
On Tue, Jun 28, 2011 at 11:35:11AM +0100, Daniel P. Berrange wrote: On Mon, Jun 27, 2011 at 02:49:37PM -0600, Eric Blake wrote: On 06/27/2011 02:08 PM, Eric Blake wrote: @@ -874,26 +646,14 @@ doRemoteOpen (virConnectPtr conn, /* Now try and find out what URI the daemon used */

Re: [libvirt] [PATCH 1/4] Convert the remote driver to new RPC client APIs

2011-06-27 Thread Eric Blake
On 06/27/2011 02:08 PM, Eric Blake wrote: Aargh, I hit send too soon. +case trans_ext: { +char const *cmd_argv[] = { command, NULL }; +if (!(priv-client = virNetClientNewExternal(cmd_argv))) This appears to be the only call to virNetClientNewExternal. And it only passes