Re: [libvirt] [PATCH 1/4] Fix docs for PM event callbacks

2012-09-07 Thread Jiri Denemark
On Thu, Sep 06, 2012 at 17:48:49 -0600, Eric Blake wrote: On 09/06/2012 05:29 PM, Doug Goldstein wrote: On Thu, Sep 6, 2012 at 10:09 AM, Jiri Denemark jdene...@redhat.com wrote: PM{Suspend,Wakeup} event callbacks were designed with a reason parameter which could be used in the future.

[libvirt] [PATCH 1/4] Fix docs for PM event callbacks

2012-09-06 Thread Jiri Denemark
PM{Suspend,Wakeup} event callbacks were designed with a reason parameter which could be used in the future. However, we do not transfer the reason over RPC and thus we can never use it in the future. Make it explicit in the docs. --- include/libvirt/libvirt.h.in | 6 ++ 1 file changed, 2

Re: [libvirt] [PATCH 1/4] Fix docs for PM event callbacks

2012-09-06 Thread Doug Goldstein
On Thu, Sep 6, 2012 at 10:09 AM, Jiri Denemark jdene...@redhat.com wrote: PM{Suspend,Wakeup} event callbacks were designed with a reason parameter which could be used in the future. However, we do not transfer the reason over RPC and thus we can never use it in the future. Make it explicit in

Re: [libvirt] [PATCH 1/4] Fix docs for PM event callbacks

2012-09-06 Thread Eric Blake
On 09/06/2012 05:29 PM, Doug Goldstein wrote: On Thu, Sep 6, 2012 at 10:09 AM, Jiri Denemark jdene...@redhat.com wrote: PM{Suspend,Wakeup} event callbacks were designed with a reason parameter which could be used in the future. However, we do not transfer the reason over RPC and thus we can