Re: [libvirt] [PATCH 1/4] Unify checking for machine1 systemd service

2017-02-28 Thread Marc Hartmayer
On Thu, Feb 23, 2017 at 12:53 PM +0100, Ján Tomko wrote: > Both virSystemdTerminateMachine and virSystemdCreateMachine > propagate the error to tell between a non-systemd system > and a hard error. > > In virSystemdGetMachineNameByPID both are treated the same, > but an error

Re: [libvirt] [PATCH 1/4] Unify checking for machine1 systemd service

2017-02-24 Thread Pavel Hrdina
On Thu, Feb 23, 2017 at 12:53:06PM +0100, Ján Tomko wrote: > Both virSystemdTerminateMachine and virSystemdCreateMachine > propagate the error to tell between a non-systemd system > and a hard error. > > In virSystemdGetMachineNameByPID both are treated the same, > but an error is ignored by the

[libvirt] [PATCH 1/4] Unify checking for machine1 systemd service

2017-02-23 Thread Ján Tomko
Both virSystemdTerminateMachine and virSystemdCreateMachine propagate the error to tell between a non-systemd system and a hard error. In virSystemdGetMachineNameByPID both are treated the same, but an error is ignored by the callers. Split out the checks into a separate function. ---