Re: [libvirt] [PATCH 1/4] backup: Prepare for Unix sockets in QMP nbd-server-start

On Mon, Jun 10, 2019 at 12:11:34 -0500, Eric Blake wrote: > On 6/7/19 7:06 AM, Peter Krempa wrote: > > On Fri, Jun 07, 2019 at 10:13:04 +0200, Peter Krempa wrote: > >> On Thu, Jun 06, 2019 at 08:40:14 -0500, Eric Blake wrote: > >>> On 6/6/19 7:53 AM, Peter Krempa wrote: > > > > [...] > > > >> In

Re: [libvirt] [PATCH 1/4] backup: Prepare for Unix sockets in QMP nbd-server-start

On 6/7/19 7:06 AM, Peter Krempa wrote: > On Fri, Jun 07, 2019 at 10:13:04 +0200, Peter Krempa wrote: >> On Thu, Jun 06, 2019 at 08:40:14 -0500, Eric Blake wrote: >>> On 6/6/19 7:53 AM, Peter Krempa wrote: > > [...] > >> In this case I feel it's more useful to do the check against the schema >>

Re: [libvirt] [PATCH 1/4] backup: Prepare for Unix sockets in QMP nbd-server-start

On Fri, Jun 07, 2019 at 10:13:04 +0200, Peter Krempa wrote: > On Thu, Jun 06, 2019 at 08:40:14 -0500, Eric Blake wrote: > > On 6/6/19 7:53 AM, Peter Krempa wrote: [...] > In this case I feel it's more useful to do the check against the schema > rather than to see that the resposne is the same. >

Re: [libvirt] [PATCH 1/4] backup: Prepare for Unix sockets in QMP nbd-server-start

On Thu, Jun 06, 2019 at 08:40:14 -0500, Eric Blake wrote: > On 6/6/19 7:53 AM, Peter Krempa wrote: > > On Wed, Jun 05, 2019 at 22:01:07 -0500, Eric Blake wrote: > >> Migration always uses a TCP socket for NBD servers, because we don't > >> support same-host migration. But upcoming pull-mode

Re: [libvirt] [PATCH 1/4] backup: Prepare for Unix sockets in QMP nbd-server-start

On 6/6/19 7:53 AM, Peter Krempa wrote: > On Wed, Jun 05, 2019 at 22:01:07 -0500, Eric Blake wrote: >> Migration always uses a TCP socket for NBD servers, because we don't >> support same-host migration. But upcoming pull-mode incremental backup >> needs to also support a Unix socket, for

Re: [libvirt] [PATCH 1/4] backup: Prepare for Unix sockets in QMP nbd-server-start

On Wed, Jun 05, 2019 at 22:01:07 -0500, Eric Blake wrote: > Migration always uses a TCP socket for NBD servers, because we don't > support same-host migration. But upcoming pull-mode incremental backup > needs to also support a Unix socket, for retrieving the backup from > the same host. Support

[libvirt] [PATCH 1/4] backup: Prepare for Unix sockets in QMP nbd-server-start

Migration always uses a TCP socket for NBD servers, because we don't support same-host migration. But upcoming pull-mode incremental backup needs to also support a Unix socket, for retrieving the backup from the same host. Support this by plumbing virStorageNetHostDef through the monitor calls,