Re: [libvirt] [PATCH 1/4] latency: Introduce new members for _virDomainBlockStats

2011-08-22 Thread Richard W.M. Jones
On Wed, Aug 17, 2011 at 11:15:29AM -0600, Eric Blake wrote: > But I'm unclear from your answer whether you are opposed to the > overall idea of reusing virDomainBlockStats() with the size argument > as the key on which struct was passed in [...] I will just say that (rightly or wrongly) the size

Re: [libvirt] [PATCH 1/4] latency: Introduce new members for _virDomainBlockStats

2011-08-18 Thread Osier Yang
于 2011年08月18日 01:15, Eric Blake 写道: On 08/17/2011 10:10 AM, Daniel P. Berrange wrote: 2. recompiling an existing client against newer libvirt.h with no other changes will automatically pick up the larger struct. The sizeof() argument will change. Newer servers will recognize the larger struct

Re: [libvirt] [PATCH 1/4] latency: Introduce new members for _virDomainBlockStats

2011-08-18 Thread Eric Blake
On 08/18/2011 08:40 AM, Adam Litke wrote: The following libvirt interfaces take a flags parameter, and could be extensible by setting a flag bit that says a larger struct is in use: virDomainGetControlInfo virNodeGetCPUStats virNodeGetMemoryStats virDomainMemoryStats virDomainMemoryStats() was

Re: [libvirt] [PATCH 1/4] latency: Introduce new members for _virDomainBlockStats

2011-08-18 Thread Adam Litke
On 08/17/2011 12:15 PM, Eric Blake wrote: > I just audited libvirt.c, and found that the following libvirt > interfaces that take a size parameter, and could be extensible by use of > the size field: > virDomainBlockStats > virDomainInterfaceStats > > The following libvirt interfaces take a flag

Re: [libvirt] [PATCH 1/4] latency: Introduce new members for _virDomainBlockStats

2011-08-17 Thread Eric Blake
On 08/17/2011 10:10 AM, Daniel P. Berrange wrote: 2. recompiling an existing client against newer libvirt.h with no other changes will automatically pick up the larger struct. The sizeof() argument will change. Newer servers will recognize the larger struct and automatically call the newer RPC,

Re: [libvirt] [PATCH 1/4] latency: Introduce new members for _virDomainBlockStats

2011-08-17 Thread Daniel P. Berrange
On Wed, Aug 17, 2011 at 09:39:34AM -0600, Eric Blake wrote: > On 08/12/2011 07:53 AM, Daniel P. Berrange wrote: > >On Fri, Aug 12, 2011 at 10:17:24PM +0800, Osier Yang wrote: > >>The new disk latency related members include: > >> rd_total_times > >> wr_total_times > >> flush_operations

Re: [libvirt] [PATCH 1/4] latency: Introduce new members for _virDomainBlockStats

2011-08-17 Thread Daniel Veillard
On Wed, Aug 17, 2011 at 09:39:34AM -0600, Eric Blake wrote: > On 08/12/2011 07:53 AM, Daniel P. Berrange wrote: > >On Fri, Aug 12, 2011 at 10:17:24PM +0800, Osier Yang wrote: > >>The new disk latency related members include: > >> rd_total_times > >> wr_total_times > >> flush_operations

Re: [libvirt] [PATCH 1/4] latency: Introduce new members for _virDomainBlockStats

2011-08-17 Thread Eric Blake
On 08/12/2011 07:53 AM, Daniel P. Berrange wrote: On Fri, Aug 12, 2011 at 10:17:24PM +0800, Osier Yang wrote: The new disk latency related members include: rd_total_times wr_total_times flush_operations flush_total_times --- include/libvirt/libvirt.h.in |4 1 file

Re: [libvirt] [PATCH 1/4] latency: Introduce new members for _virDomainBlockStats

2011-08-12 Thread Daniel P. Berrange
On Fri, Aug 12, 2011 at 10:17:24PM +0800, Osier Yang wrote: > The new disk latency related members include: > rd_total_times > wr_total_times > flush_operations > flush_total_times > --- > include/libvirt/libvirt.h.in |4 > 1 files changed, 4 insertions(+), 0 deletions(-)

[libvirt] [PATCH 1/4] latency: Introduce new members for _virDomainBlockStats

2011-08-12 Thread Osier Yang
The new disk latency related members include: rd_total_times wr_total_times flush_operations flush_total_times --- include/libvirt/libvirt.h.in |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in in