Re: [libvirt] [PATCH 1/4] libxl: honor domain lifecycle event configuration

2014-02-24 Thread Michal Privoznik
On 21.02.2014 00:02, Jim Fehlig wrote: The libxl driver was ignoring the on_* domain event configuration, causing e.g. a domain to be rebooted even when on_reboot is set to destroy. This patch honors the on_* configuration in the shutdown event handler. Signed-off-by: Jim Fehlig

Re: [libvirt] [PATCH 1/4] libxl: honor domain lifecycle event configuration

2014-02-24 Thread Jim Fehlig
Michal Privoznik wrote: On 21.02.2014 00:02, Jim Fehlig wrote: The libxl driver was ignoring the on_* domain event configuration, causing e.g. a domain to be rebooted even when on_reboot is set to destroy. This patch honors the on_* configuration in the shutdown event handler.

Re: [libvirt] [PATCH 1/4] libxl: honor domain lifecycle event configuration

2014-02-24 Thread Michal Privoznik
On 24.02.2014 15:56, Jim Fehlig wrote: Michal Privoznik wrote: On 21.02.2014 00:02, Jim Fehlig wrote: The libxl driver was ignoring the on_* domain event configuration, causing e.g. a domain to be rebooted even when on_reboot is set to destroy. This patch honors the on_* configuration in the

Re: [libvirt] [PATCH 1/4] libxl: honor domain lifecycle event configuration

2014-02-24 Thread Daniel P. Berrange
On Mon, Feb 24, 2014 at 04:17:52PM +0100, Michal Privoznik wrote: On 24.02.2014 15:56, Jim Fehlig wrote: Michal Privoznik wrote: On 21.02.2014 00:02, Jim Fehlig wrote: The libxl driver was ignoring the on_* domain event configuration, causing e.g. a domain to be rebooted even when on_reboot

Re: [libvirt] [PATCH 1/4] libxl: honor domain lifecycle event configuration

2014-02-24 Thread Jim Fehlig
Michal Privoznik wrote: On 24.02.2014 15:56, Jim Fehlig wrote: Can this series be pushed for 1.2.2? If so, I'll squash in your changes and push later today. Thanks for the review! Regards, Jim I think these patches are bugfix. Which allows us to push them even in freeze. Also note

[libvirt] [PATCH 1/4] libxl: honor domain lifecycle event configuration

2014-02-20 Thread Jim Fehlig
The libxl driver was ignoring the on_* domain event configuration, causing e.g. a domain to be rebooted even when on_reboot is set to destroy. This patch honors the on_* configuration in the shutdown event handler. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 83

Re: [libvirt] [PATCH 1/4] libxl: honor domain lifecycle event configuration

2014-02-20 Thread Jim Fehlig
Jim Fehlig wrote: The libxl driver was ignoring the on_* domain event configuration, causing e.g. a domain to be rebooted even when on_reboot is set to destroy. This patch honors the on_* configuration in the shutdown event handler. Signed-off-by: Jim Fehlig jfeh...@suse.com ---