Re: [libvirt] [PATCH 1/4] qemu: Add checking in helpers for sgio setting

2013-02-11 Thread Osier Yang
On 2013年02月11日 19:14, Daniel P. Berrange wrote: On Mon, Feb 11, 2013 at 07:09:29PM +0800, Osier Yang wrote: On 2013年02月11日 18:48, Daniel P. Berrange wrote: On Mon, Feb 11, 2013 at 06:35:42PM +0800, Osier Yang wrote: On 2013年02月09日 04:21, John Ferlan wrote: On 02/08/2013 08:07 AM, Osier Yang w

Re: [libvirt] [PATCH 1/4] qemu: Add checking in helpers for sgio setting

2013-02-11 Thread Daniel P. Berrange
On Mon, Feb 11, 2013 at 07:09:29PM +0800, Osier Yang wrote: > On 2013年02月11日 18:48, Daniel P. Berrange wrote: > >On Mon, Feb 11, 2013 at 06:35:42PM +0800, Osier Yang wrote: > >>On 2013年02月09日 04:21, John Ferlan wrote: > >>>On 02/08/2013 08:07 AM, Osier Yang wrote: > This moves the checking into

Re: [libvirt] [PATCH 1/4] qemu: Add checking in helpers for sgio setting

2013-02-11 Thread Osier Yang
On 2013年02月11日 18:48, Daniel P. Berrange wrote: On Mon, Feb 11, 2013 at 06:35:42PM +0800, Osier Yang wrote: On 2013年02月09日 04:21, John Ferlan wrote: On 02/08/2013 08:07 AM, Osier Yang wrote: This moves the checking into the helpers, to avoid the callers missing the checking. --- src/qemu/qem

Re: [libvirt] [PATCH 1/4] qemu: Add checking in helpers for sgio setting

2013-02-11 Thread Daniel P. Berrange
On Mon, Feb 11, 2013 at 06:35:42PM +0800, Osier Yang wrote: > On 2013年02月09日 04:21, John Ferlan wrote: > >On 02/08/2013 08:07 AM, Osier Yang wrote: > >>This moves the checking into the helpers, to avoid the > >>callers missing the checking. > >>--- > >> src/qemu/qemu_conf.c| 20 +

Re: [libvirt] [PATCH 1/4] qemu: Add checking in helpers for sgio setting

2013-02-11 Thread Osier Yang
On 2013年02月09日 04:21, John Ferlan wrote: On 02/08/2013 08:07 AM, Osier Yang wrote: This moves the checking into the helpers, to avoid the callers missing the checking. --- src/qemu/qemu_conf.c| 20 src/qemu/qemu_conf.h|4 ++-- src/qemu/qemu_driver.c | 18

Re: [libvirt] [PATCH 1/4] qemu: Add checking in helpers for sgio setting

2013-02-08 Thread John Ferlan
On 02/08/2013 08:07 AM, Osier Yang wrote: > This moves the checking into the helpers, to avoid the > callers missing the checking. > --- > src/qemu/qemu_conf.c| 20 > src/qemu/qemu_conf.h|4 ++-- > src/qemu/qemu_driver.c | 18 +++--- > src/qemu/qem

[libvirt] [PATCH 1/4] qemu: Add checking in helpers for sgio setting

2013-02-08 Thread Osier Yang
This moves the checking into the helpers, to avoid the callers missing the checking. --- src/qemu/qemu_conf.c| 20 src/qemu/qemu_conf.h|4 ++-- src/qemu/qemu_driver.c | 18 +++--- src/qemu/qemu_process.c | 21 - 4 files change