Re: [libvirt] [PATCH 1/4] qemu: Advertise ACPI support for aarch64 guests

2017-03-27 Thread John Ferlan
On 03/27/2017 10:39 AM, Andrea Bolognani wrote: > On Mon, 2017-03-27 at 10:26 -0400, John Ferlan wrote: > [...] Considering on what's coming in patch 2, this would be better as a virQEMUCapsSetFirmwareCaps? "utility" function... That way the added comments in both places

Re: [libvirt] [PATCH 1/4] qemu: Advertise ACPI support for aarch64 guests

2017-03-27 Thread Andrea Bolognani
On Mon, 2017-03-27 at 10:26 -0400, John Ferlan wrote: [...] > > > Considering on what's coming in patch 2, this would be better as a > > > virQEMUCapsSetFirmwareCaps? "utility" function...  That way the added > > > comments in both places referencing the other place could be dropped. > >  > > HPET

Re: [libvirt] [PATCH 1/4] qemu: Advertise ACPI support for aarch64 guests

2017-03-27 Thread John Ferlan
On 03/27/2017 09:57 AM, Andrea Bolognani wrote: > On Mon, 2017-03-27 at 08:03 -0400, John Ferlan wrote: > [...] >>> +/* Older QEMU versions reported -no-acpi in the output of -help even >>> + * though it was not supported by the architecture. The issue has since >>> + * been fixed,

Re: [libvirt] [PATCH 1/4] qemu: Advertise ACPI support for aarch64 guests

2017-03-27 Thread Andrea Bolognani
On Mon, 2017-03-27 at 08:03 -0400, John Ferlan wrote: [...] > > +/* Older QEMU versions reported -no-acpi in the output of -help even > > + * though it was not supported by the architecture. The issue has since > > + * been fixed, but to maintain compatibility with all release we still

Re: [libvirt] [PATCH 1/4] qemu: Advertise ACPI support for aarch64 guests

2017-03-27 Thread John Ferlan
On 03/09/2017 12:37 PM, Andrea Bolognani wrote: > So far, libvirt has assumed that only x86 supports ACPI, > but that's inaccurate since aarch64 supports it too. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1429509 > --- > src/qemu/qemu_capabilities.c | 28 >

[libvirt] [PATCH 1/4] qemu: Advertise ACPI support for aarch64 guests

2017-03-09 Thread Andrea Bolognani
So far, libvirt has assumed that only x86 supports ACPI, but that's inaccurate since aarch64 supports it too. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1429509 --- src/qemu/qemu_capabilities.c | 28 -- .../caps_2.6.0-gicv2.aarch64.xml