Re: [libvirt] [PATCH 1/4] qemu: During startup need more QEMU_CAPS_OBJECT_IOTHREAD checks

2015-10-14 Thread Peter Krempa
On Tue, Oct 13, 2015 at 18:31:11 -0400, John Ferlan wrote: > On 10/13/2015 12:08 PM, Peter Krempa wrote: > > On Tue, Oct 13, 2015 at 11:47:07 -0400, John Ferlan wrote: > >> During qemu process startup (qemuProcessStart), the call to > >> qemuProcessDetectIOThreadPIDs will not attempt to fill in

[libvirt] [PATCH 1/4] qemu: During startup need more QEMU_CAPS_OBJECT_IOTHREAD checks

2015-10-13 Thread John Ferlan
During qemu process startup (qemuProcessStart), the call to qemuProcessDetectIOThreadPIDs will not attempt to fill in the ->thread_id values if the binary doesn't support IOThreads. However, subsequent calls to setup the IOThread cgroups, affinity, and scheduler parameters had no such check, thus

Re: [libvirt] [PATCH 1/4] qemu: During startup need more QEMU_CAPS_OBJECT_IOTHREAD checks

2015-10-13 Thread Peter Krempa
On Tue, Oct 13, 2015 at 11:47:07 -0400, John Ferlan wrote: > During qemu process startup (qemuProcessStart), the call to > qemuProcessDetectIOThreadPIDs will not attempt to fill in the > ->thread_id values if the binary doesn't support IOThreads. > However, subsequent calls to setup the IOThread

Re: [libvirt] [PATCH 1/4] qemu: During startup need more QEMU_CAPS_OBJECT_IOTHREAD checks

2015-10-13 Thread John Ferlan
On 10/13/2015 12:08 PM, Peter Krempa wrote: > On Tue, Oct 13, 2015 at 11:47:07 -0400, John Ferlan wrote: >> During qemu process startup (qemuProcessStart), the call to >> qemuProcessDetectIOThreadPIDs will not attempt to fill in the >> ->thread_id values if the binary doesn't support IOThreads.

Re: [libvirt] [PATCH 1/4] qemu: During startup need more QEMU_CAPS_OBJECT_IOTHREAD checks

2015-10-13 Thread John Ferlan
On 10/13/2015 12:08 PM, Peter Krempa wrote: > On Tue, Oct 13, 2015 at 11:47:07 -0400, John Ferlan wrote: >> During qemu process startup (qemuProcessStart), the call to >> qemuProcessDetectIOThreadPIDs will not attempt to fill in the >> ->thread_id values if the binary doesn't support IOThreads.