Re: [libvirt] [PATCH 1/4] qemu: fix wrong errno report in qemuMonitorOpenUnix

2014-07-15 Thread Jincheng Miao
- Original Message - > virProcessKill can be called on cleanup paths. I think it might be wiser > to rewrite virProcessKill() to guarantee that it does not modify errno > than it is to make all callers have to store a temporary. Hi Eric, this virProcessKill only test whether this process

Re: [libvirt] [PATCH 1/4] qemu: fix wrong errno report in qemuMonitorOpenUnix

2014-07-15 Thread Eric Blake
On 07/15/2014 02:32 AM, Jincheng Miao wrote: > In qemuMonitorOpenUnix, after connect(), virProcessKill will be > invoked when cpid is not empty. But if the qemu-kvm process exited > early, virProcessKill will flush errno as ESRCH, so the wrong > message will be recorded in log as: > error: qemuMoni

[libvirt] [PATCH 1/4] qemu: fix wrong errno report in qemuMonitorOpenUnix

2014-07-15 Thread Jincheng Miao
In qemuMonitorOpenUnix, after connect(), virProcessKill will be invoked when cpid is not empty. But if the qemu-kvm process exited early, virProcessKill will flush errno as ESRCH, so the wrong message will be recorded in log as: error: qemuMonitorOpenUnix:309 : failed to connect to monitor socket: