Re: [libvirt] [PATCH 1/4] qemu: get arch name from element

2012-01-24 Thread Paolo Bonzini
On 01/24/2012 02:28 PM, Jiri Denemark wrote: > The idea is that, if you were using -cpu just to set "-cpu > {qemu,kvm}{32,64},-kvmclock", you will not get an irrelevant > qemu32 in domxml-from-native output. Yeah, I understand why you did so, however, you just discard {qemu,kvm}{32,64} model

Re: [libvirt] [PATCH 1/4] qemu: get arch name from element

2012-01-24 Thread Jiri Denemark
On Mon, Jan 23, 2012 at 17:21:01 +0100, Paolo Bonzini wrote: > On 01/23/2012 04:52 PM, Jiri Denemark wrote: > > I think we could just set cpu->model even if the model used in qemu command > > line was {qemu,kvm}{32,64}. That would probably mean we need to add some of > > the models in cpu_map.xml,

Re: [libvirt] [PATCH 1/4] qemu: get arch name from element

2012-01-23 Thread Paolo Bonzini
On 01/23/2012 04:52 PM, Jiri Denemark wrote: I think we could just set cpu->model even if the model used in qemu command line was {qemu,kvm}{32,64}. That would probably mean we need to add some of the models in cpu_map.xml, though. Actually I was doing that on purpose, not just for laziness. :)

Re: [libvirt] [PATCH 1/4] qemu: get arch name from element

2012-01-23 Thread Jiri Denemark
On Mon, Jan 23, 2012 at 14:11:08 +0100, Paolo Bonzini wrote: > The qemu32 CPU model is chosen based on the name when > creating the QEMU command line. Reflect the kvm32/kvm64/qemu32/qemu64 > CPU models in the element when doing the opposite transformation. > To do this, we need to not look at de

[libvirt] [PATCH 1/4] qemu: get arch name from element

2012-01-23 Thread Paolo Bonzini
The qemu32 CPU model is chosen based on the name when creating the QEMU command line. Reflect the kvm32/kvm64/qemu32/qemu64 CPU models in the element when doing the opposite transformation. To do this, we need to not look at def->os.arch until after the command-line has been parsed. At the same