Re: [libvirt] [PATCH 1/4] qemu: migration: Don't pass around flags for different API

2019-05-21 Thread Ján Tomko
On Mon, May 20, 2019 at 04:16:30PM +0200, Peter Krempa wrote: The NBD migration code uses drive/blockdev-mirror internally. In those APIs we pass around flags for the monitor commands which are based on the flags for the virDomainBlockRebase API. Since there's only one flag which changes, pass it

[libvirt] [PATCH 1/4] qemu: migration: Don't pass around flags for different API

2019-05-20 Thread Peter Krempa
The NBD migration code uses drive/blockdev-mirror internally. In those APIs we pass around flags for the monitor commands which are based on the flags for the virDomainBlockRebase API. Since there's only one flag which changes, pass it around explicitly rather than obscuring it in a bitfield. Sign