Re: [libvirt] [PATCH 1/4] qemuDomainBlockCommit: Don't track top_canon path separately

2014-04-24 Thread Jiri Denemark
On Thu, Apr 24, 2014 at 08:47:34 -0600, Eric Blake wrote: > On 04/22/2014 06:49 AM, Jiri Denemark wrote: > > virStorageFileChainLookup is able to give use virStorageSourcePtr which > > contains the pointer to its canonical path. There's no need for the > > caller to store both of them. > > > > For

Re: [libvirt] [PATCH 1/4] qemuDomainBlockCommit: Don't track top_canon path separately

2014-04-24 Thread Eric Blake
On 04/22/2014 06:49 AM, Jiri Denemark wrote: > virStorageFileChainLookup is able to give use virStorageSourcePtr which > contains the pointer to its canonical path. There's no need for the > caller to store both of them. > > Former top_meta maps to topSource and top_canon maps to topSource->path.

[libvirt] [PATCH 1/4] qemuDomainBlockCommit: Don't track top_canon path separately

2014-04-22 Thread Jiri Denemark
virStorageFileChainLookup is able to give use virStorageSourcePtr which contains the pointer to its canonical path. There's no need for the caller to store both of them. Former top_meta maps to topSource and top_canon maps to topSource->path. Signed-off-by: Jiri Denemark --- src/qemu/qemu_drive