Re: [libvirt] [PATCH 1/4] remote_daemon_dispatch: Check for limit properly in remoteDispatchConnectGetAllDomainStats

2019-08-27 Thread Jonathon Jongsma
Looks correct to me. Good catch. Reviewed-by: Jonathon Jongsma On Tue, 2019-08-27 at 14:05 +0200, Michal Privoznik wrote: > The return structure is a bit complicated and that's why it is > very easy to check for RPC limits incorrectly. The structure is > an array of remote_domain_stats_record

[libvirt] [PATCH 1/4] remote_daemon_dispatch: Check for limit properly in remoteDispatchConnectGetAllDomainStats

2019-08-27 Thread Michal Privoznik
The return structure is a bit complicated and that's why it is very easy to check for RPC limits incorrectly. The structure is an array of remote_domain_stats_record structures with the limit of REMOTE_DOMAIN_LIST_MAX. The latter structure then poses a different limit on typed params: