Re: [libvirt] [PATCH 1/4] storage: factor out large integer reads

2013-02-08 Thread Eric Blake
On 02/07/2013 07:53 AM, Daniel P. Berrange wrote: > On Wed, Feb 06, 2013 at 10:10:17PM -0700, Eric Blake wrote: >> This makes code easier to read, by avoiding lines longer than >> 80 columns and removing the repetition from the callers. >> > > How about putting these helpful APIs in some other sr

Re: [libvirt] [PATCH 1/4] storage: factor out large integer reads

2013-02-07 Thread Daniel P. Berrange
On Wed, Feb 06, 2013 at 10:10:17PM -0700, Eric Blake wrote: > This makes code easier to read, by avoiding lines longer than > 80 columns and removing the repetition from the callers. > > * src/util/virstoragefile.c (virRead64BE, virRead64LE) > (virRead32BE, virRead32LE): New helper functions. > (q

[libvirt] [PATCH 1/4] storage: factor out large integer reads

2013-02-06 Thread Eric Blake
This makes code easier to read, by avoiding lines longer than 80 columns and removing the repetition from the callers. * src/util/virstoragefile.c (virRead64BE, virRead64LE) (virRead32BE, virRead32LE): New helper functions. (qedGetHeaderUL, qedGetHeaderULL): Delete in favor of more generic name. (