Re: [libvirt] [PATCH 1/4] xen: Make xenDaemon*DeviceFlags errors less confusing

2010-10-06 Thread Eric Blake
On 10/04/2010 05:47 AM, Jiri Denemark wrote: Should we always error out if _LIVE and inactive, or should we special-case _CONFIG|_LIVE by silently ignoring the _LIVE flag on inactive domains? Since there is the _CURRENT variant of the flag, erroring out if _LIVE and inactive seems like the

[libvirt] [PATCH 1/4] xen: Make xenDaemon*DeviceFlags errors less confusing

2010-10-01 Thread Jiri Denemark
When a user calls to virDomain{Attach,Detach,Update}DeviceFlags() with flags == VIR_DOMAIN_DEVICE_MODIFY_LIVE on an inactive guest running on an old Xen hypervisor (such as RHEL-5) xend_internal driver reports: Xend version does not support modifying persistent config which is pretty

Re: [libvirt] [PATCH 1/4] xen: Make xenDaemon*DeviceFlags errors less confusing

2010-10-01 Thread Eric Blake
On 10/01/2010 02:09 PM, Jiri Denemark wrote: When a user calls to virDomain{Attach,Detach,Update}DeviceFlags() with flags == VIR_DOMAIN_DEVICE_MODIFY_LIVE on an inactive guest running on an old Xen hypervisor (such as RHEL-5) xend_internal driver reports: Xend version does not support