Re: [libvirt] [PATCH 1/5] lib: Add public api to enable atomic listing of guest

2012-05-23 Thread Daniel P. Berrange
On Mon, May 21, 2012 at 04:42:41PM -0600, Eric Blake wrote: +int virConnectListAllDomains (virConnectPtr conn, + virDomainPtr **domains, Hmm - time for me to think out loud. Your signature differs from mine. I proposed:

Re: [libvirt] [PATCH 1/5] lib: Add public api to enable atomic listing of guest

2012-05-21 Thread Eric Blake
On 05/20/2012 09:56 AM, Peter Krempa wrote: This patch adds a new public api that lists domains. The new approach is different from those used before. There are four key points to this: 1) The list is acquired atomicaly and contains both active and inactive s/atomicaly/atomically/ domains

[libvirt] [PATCH 1/5] lib: Add public api to enable atomic listing of guest

2012-05-20 Thread Peter Krempa
This patch adds a new public api that lists domains. The new approach is different from those used before. There are four key points to this: 1) The list is acquired atomicaly and contains both active and inactive domains (guests). This eliminates the need to call two different list APIs, where