Re: [libvirt] [PATCH 1/5] qemu: Remove dead code in qemuDomainAssignPCIAddresses revert patch

2015-01-23 Thread Ján Tomko
On 01/21/2015 05:49 PM, Erik Skultety wrote: > As it turned out, fix of dead code 419a22 changed the affected condition > from "never true" to "always true", so better fix would be to change the > return code of virDomainMaybeAddController from 0 to 1 if > a new bridge has been added, thus distingu

[libvirt] [PATCH 1/5] qemu: Remove dead code in qemuDomainAssignPCIAddresses revert patch

2015-01-21 Thread Erik Skultety
As it turned out, fix of dead code 419a22 changed the affected condition from "never true" to "always true", so better fix would be to change the return code of virDomainMaybeAddController from 0 to 1 if a new bridge has been added, thus distinguishing case when we didn't need to add any controller