Re: [libvirt] [PATCH 1/5] util: Introduce function for allocating virStorageSource

2019-02-18 Thread Erik Skultety
On Mon, Feb 18, 2019 at 10:16:25AM +0100, Peter Krempa wrote: > On Mon, Feb 18, 2019 at 08:29:14 +0100, Erik Skultety wrote: > > On Fri, Feb 15, 2019 at 01:42:09PM +0100, Peter Krempa wrote: > > > Add virStorageSourceNew and refactor places allocating that structure to > > > use the helper. > > >

Re: [libvirt] [PATCH 1/5] util: Introduce function for allocating virStorageSource

2019-02-18 Thread Peter Krempa
On Mon, Feb 18, 2019 at 08:29:14 +0100, Erik Skultety wrote: > On Fri, Feb 15, 2019 at 01:42:09PM +0100, Peter Krempa wrote: > > Add virStorageSourceNew and refactor places allocating that structure to > > use the helper. > > > > Signed-off-by: Peter Krempa > > --- > Looks like you caught all the

Re: [libvirt] [PATCH 1/5] util: Introduce function for allocating virStorageSource

2019-02-17 Thread Erik Skultety
On Fri, Feb 15, 2019 at 01:42:09PM +0100, Peter Krempa wrote: > Add virStorageSourceNew and refactor places allocating that structure to > use the helper. > > Signed-off-by: Peter Krempa > --- Looks like you caught all the occurrences but 1 in bhyve: bhyveParsePCIDisk With that addressed too:

[libvirt] [PATCH 1/5] util: Introduce function for allocating virStorageSource

2019-02-15 Thread Peter Krempa
Add virStorageSourceNew and refactor places allocating that structure to use the helper. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c| 10 +- src/conf/snapshot_conf.c | 4 ++-- src/conf/storage_conf.c | 2 +-