Re: [libvirt] [PATCH 1/5] vcpupin: introduce the new libvirt API (virDomainGetVcpupinInfo)

2011-06-24 Thread Eric Blake
On 06/24/2011 02:37 PM, Matthias Bolte wrote: > 2011/6/24 Taku Izumi : >> >> This patch introduces a new libvirt API (virDomainGetVcpupinInfo). > > Just a comment on the name. I'd write pin with a capital P: > virDomainGetVcpuPinInfo Sure, I'll refactor that into my amendments to the patch series

Re: [libvirt] [PATCH 1/5] vcpupin: introduce the new libvirt API (virDomainGetVcpupinInfo)

2011-06-24 Thread Matthias Bolte
2011/6/24 Taku Izumi : > > This patch introduces a new libvirt API (virDomainGetVcpupinInfo). Just a comment on the name. I'd write pin with a capital P: virDomainGetVcpuPinInfo -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.c

Re: [libvirt] [PATCH 1/5] vcpupin: introduce the new libvirt API (virDomainGetVcpupinInfo)

2011-06-24 Thread Eric Blake
On 06/24/2011 02:56 AM, Taku Izumi wrote: > > This patch introduces a new libvirt API (virDomainGetVcpupinInfo). > > We can use virDomainGetVcpus API to retrieve CPU affinity information, > but can't use this API against inactive domains (at least in case of KVM). > There is the companion API of

Re: [libvirt] [PATCH 1/5] vcpupin: introduce the new libvirt API (virDomainGetVcpupinInfo)

2011-06-24 Thread Eric Blake
On 06/24/2011 09:12 AM, Eric Blake wrote: > On 06/24/2011 08:53 AM, Daniel Veillard wrote: >>> >>> +int virDomainGetVcpupinInfo (virDomainPtr domain, >>> + int maxinfo, >>> + unsign

Re: [libvirt] [PATCH 1/5] vcpupin: introduce the new libvirt API (virDomainGetVcpupinInfo)

2011-06-24 Thread Eric Blake
On 06/24/2011 08:53 AM, Daniel Veillard wrote: >> >> +int virDomainGetVcpupinInfo (virDomainPtr domain, >> + int maxinfo, >> + unsigned char *cpumaps, >> +

Re: [libvirt] [PATCH 1/5] vcpupin: introduce the new libvirt API (virDomainGetVcpupinInfo)

2011-06-24 Thread Daniel Veillard
On Fri, Jun 24, 2011 at 05:56:21PM +0900, Taku Izumi wrote: > > This patch introduces a new libvirt API (virDomainGetVcpupinInfo). > > We can use virDomainGetVcpus API to retrieve CPU affinity information, > but can't use this API against inactive domains (at least in case of KVM). > There is the

[libvirt] [PATCH 1/5] vcpupin: introduce the new libvirt API (virDomainGetVcpupinInfo)

2011-06-24 Thread Taku Izumi
This patch introduces a new libvirt API (virDomainGetVcpupinInfo). We can use virDomainGetVcpus API to retrieve CPU affinity information, but can't use this API against inactive domains (at least in case of KVM). There is the companion API of this, whose name is virDomainGetVcpusFlags. However i