Re: [libvirt] [PATCH 1/5]virsh: disable config readonly and shareable in virsh command

2013-10-23 Thread Chen Hanxiao
> -Original Message- > From: Eric Blake [mailto:ebl...@redhat.com] > Sent: Wednesday, October 23, 2013 5:49 PM > To: Chen Hanxiao; 'Michal Privoznik' > Cc: libvir-list@redhat.com > Subject: Re: [libvirt] [PATCH 1/5]virsh: disable config readonly and &g

Re: [libvirt] [PATCH 1/5]virsh: disable config readonly and shareable in virsh command

2013-10-23 Thread Eric Blake
On 10/23/2013 09:57 AM, Chen Hanxiao wrote: >> I don't think either of these approaches are needed. If you make >> --shareable an undocumented alias of --mode=shareable, then the alias >> handling code will already guarantee that only one of the two spellings >> appears, and you don't have to do

Re: [libvirt] [PATCH 1/5]virsh: disable config readonly and shareable in virsh command

2013-10-23 Thread Chen Hanxiao
Hi > -Original Message- > From: Eric Blake [mailto:ebl...@redhat.com] > Sent: Tuesday, October 22, 2013 2:26 PM > To: Michal Privoznik; Chen Hanxiao > Cc: libvir-list@redhat.com > > > > > -if (vshCommandOptBool(cmd, "shareable")) > > +if (vshCommandOptBool(cmd, "shareable")) { > >

Re: [libvirt] [PATCH 1/5]virsh: disable config readonly and shareable in virsh command

2013-10-22 Thread Chen Hanxiao
> -Original Message- > From: Eric Blake [mailto:ebl...@redhat.com] > Sent: Tuesday, October 22, 2013 2:26 PM > To: Michal Privoznik; Chen Hanxiao > Cc: libvir-list@redhat.com > Subject: Re: [libvirt] [PATCH 1/5]virsh: disable config readonly and > shareable in >

Re: [libvirt] [PATCH 1/5]virsh: disable config readonly and shareable in virsh command

2013-10-21 Thread Eric Blake
On 10/21/2013 02:14 PM, Michal Privoznik wrote: > On 18.10.2013 07:42, Chen Hanxiao wrote: >> From: Chen Hanxiao >> >> Daneil's suggestion about flag and as follow: s/Daneil/Daniel/ >> - Exclusive read-write. This is the default >> - Shared read-write. This is the flag >> - Shared read-only.

Re: [libvirt] [PATCH 1/5]virsh: disable config readonly and shareable in virsh command

2013-10-21 Thread Chen Hanxiao
> -Original Message- > From: Michal Privoznik [mailto:mpriv...@redhat.com] > Sent: Monday, October 21, 2013 9:15 PM > To: Chen Hanxiao > Cc: libvir-list@redhat.com > Subject: Re: [libvirt] [PATCH 1/5]virsh: disable config readonly and shareable in > virsh c

Re: [libvirt] [PATCH 1/5]virsh: disable config readonly and shareable in virsh command

2013-10-21 Thread Michal Privoznik
On 18.10.2013 07:42, Chen Hanxiao wrote: > From: Chen Hanxiao > > Daneil's suggestion about flag and as follow: > - Exclusive read-write. This is the default > - Shared read-write. This is the flag > - Shared read-only. This is the flag > > So we should disable config both readonly and share

[libvirt] [PATCH 1/5]virsh: disable config readonly and shareable in virsh command

2013-10-17 Thread Chen Hanxiao
From: Chen Hanxiao Daneil's suggestion about flag and as follow: - Exclusive read-write. This is the default - Shared read-write. This is the flag - Shared read-only. This is the flag So we should disable config both readonly and shareable in virsh command to solve the confliction. For backw