> -Original Message-
> From: Eric Blake [mailto:ebl...@redhat.com]
> Sent: Wednesday, October 23, 2013 5:49 PM
> To: Chen Hanxiao; 'Michal Privoznik'
> Cc: libvir-list@redhat.com
> Subject: Re: [libvirt] [PATCH 1/5]virsh: disable config readonly and
&g
On 10/23/2013 09:57 AM, Chen Hanxiao wrote:
>> I don't think either of these approaches are needed. If you make
>> --shareable an undocumented alias of --mode=shareable, then the alias
>> handling code will already guarantee that only one of the two spellings
>> appears, and you don't have to do
Hi
> -Original Message-
> From: Eric Blake [mailto:ebl...@redhat.com]
> Sent: Tuesday, October 22, 2013 2:26 PM
> To: Michal Privoznik; Chen Hanxiao
> Cc: libvir-list@redhat.com
>
> >
> > -if (vshCommandOptBool(cmd, "shareable"))
> > +if (vshCommandOptBool(cmd, "shareable")) {
> >
> -Original Message-
> From: Eric Blake [mailto:ebl...@redhat.com]
> Sent: Tuesday, October 22, 2013 2:26 PM
> To: Michal Privoznik; Chen Hanxiao
> Cc: libvir-list@redhat.com
> Subject: Re: [libvirt] [PATCH 1/5]virsh: disable config readonly and
> shareable in
>
On 10/21/2013 02:14 PM, Michal Privoznik wrote:
> On 18.10.2013 07:42, Chen Hanxiao wrote:
>> From: Chen Hanxiao
>>
>> Daneil's suggestion about flag and as follow:
s/Daneil/Daniel/
>> - Exclusive read-write. This is the default
>> - Shared read-write. This is the flag
>> - Shared read-only.
> -Original Message-
> From: Michal Privoznik [mailto:mpriv...@redhat.com]
> Sent: Monday, October 21, 2013 9:15 PM
> To: Chen Hanxiao
> Cc: libvir-list@redhat.com
> Subject: Re: [libvirt] [PATCH 1/5]virsh: disable config readonly and
shareable in
> virsh c
On 18.10.2013 07:42, Chen Hanxiao wrote:
> From: Chen Hanxiao
>
> Daneil's suggestion about flag and as follow:
> - Exclusive read-write. This is the default
> - Shared read-write. This is the flag
> - Shared read-only. This is the flag
>
> So we should disable config both readonly and share
From: Chen Hanxiao
Daneil's suggestion about flag and as follow:
- Exclusive read-write. This is the default
- Shared read-write. This is the flag
- Shared read-only. This is the flag
So we should disable config both readonly and shareable
in virsh command to solve the confliction.
For backw
