Re: [libvirt] [PATCH 1/6] Add new API virDomainStreamDisk[Info] to header and drivers

2011-05-11 Thread Anthony Liguori
On 05/09/2011 11:09 AM, Daniel P. Berrange wrote: int virDomainBlockStreamInfo(virDomainPtr dom, const char *device, virBlockStreamInfoPtr info); Any reason you didn't just use the existing 'virDomainJobInfoPtr'

Re: [libvirt] [PATCH 1/6] Add new API virDomainStreamDisk[Info] to header and drivers

2011-05-09 Thread Daniel P. Berrange
On Mon, May 02, 2011 at 04:29:49PM -0500, Adam Litke wrote: After several long distractions, I am back to working on disk streaming. Before I hit the list with a new series of patches, I was hoping to reach some middle ground on the proposed streaming API. On Fri, 2011-04-08 at 14:31 +0100,

Re: [libvirt] [PATCH 1/6] Add new API virDomainStreamDisk[Info] to header and drivers

2011-05-09 Thread Adam Litke
On 05/09/2011 11:09 AM, Daniel P. Berrange wrote: On Mon, May 02, 2011 at 04:29:49PM -0500, Adam Litke wrote: After several long distractions, I am back to working on disk streaming. Before I hit the list with a new series of patches, I was hoping to reach some middle ground on the proposed

Re: [libvirt] [PATCH 1/6] Add new API virDomainStreamDisk[Info] to header and drivers

2011-05-03 Thread Stefan Hajnoczi
On Mon, May 02, 2011 at 04:29:49PM -0500, Adam Litke wrote: typedef enum { /* If set, virDomainBlockAllocate() will return immediately * allowing polling for operation completion status */ VIR_DOMAIN_DISK_STREAM_NONBLOCK, }

Re: [libvirt] [PATCH 1/6] Add new API virDomainStreamDisk[Info] to header and drivers

2011-05-02 Thread Adam Litke
After several long distractions, I am back to working on disk streaming. Before I hit the list with a new series of patches, I was hoping to reach some middle ground on the proposed streaming API. On Fri, 2011-04-08 at 14:31 +0100, Daniel P. Berrange wrote: On Thu, Apr 07, 2011 at 04:31:59PM

Re: [libvirt] [PATCH 1/6] Add new API virDomainStreamDisk[Info] to header and drivers

2011-05-02 Thread Eric Blake
On 05/02/2011 03:29 PM, Adam Litke wrote: After several long distractions, I am back to working on disk streaming. Before I hit the list with a new series of patches, I was hoping to reach some middle ground on the proposed streaming API. Using flags to combine two separate tasks into one

Re: [libvirt] [PATCH 1/6] Add new API virDomainStreamDisk[Info] to header and drivers

2011-04-12 Thread Daniel P. Berrange
On Mon, Apr 11, 2011 at 05:06:54PM -0500, Anthony Liguori wrote: On 04/11/2011 04:45 PM, Daniel P. Berrange wrote: On Fri, Apr 08, 2011 at 02:26:48PM -0500, Anthony Liguori wrote: On 04/08/2011 11:02 AM, Stefan Hajnoczi wrote: On Fri, Apr 8, 2011 at 2:31 PM, Daniel P.

Re: [libvirt] [PATCH 1/6] Add new API virDomainStreamDisk[Info] to header and drivers

2011-04-12 Thread Kevin Wolf
Am 12.04.2011 10:14, schrieb Daniel P. Berrange: On Mon, Apr 11, 2011 at 05:06:54PM -0500, Anthony Liguori wrote: On 04/11/2011 04:45 PM, Daniel P. Berrange wrote: On Fri, Apr 08, 2011 at 02:26:48PM -0500, Anthony Liguori wrote: On 04/08/2011 11:02 AM, Stefan Hajnoczi wrote: On Fri, Apr 8,

Re: [libvirt] [PATCH 1/6] Add new API virDomainStreamDisk[Info] to header and drivers

2011-04-11 Thread Daniel P. Berrange
On Fri, Apr 08, 2011 at 02:26:48PM -0500, Anthony Liguori wrote: On 04/08/2011 11:02 AM, Stefan Hajnoczi wrote: On Fri, Apr 8, 2011 at 2:31 PM, Daniel P. Berrangeberra...@redhat.com wrote: I have CCed Anthony and Kevin. Anthony drove the QED image streaming and Kevin will probably be

Re: [libvirt] [PATCH 1/6] Add new API virDomainStreamDisk[Info] to header and drivers

2011-04-08 Thread Daniel P. Berrange
On Thu, Apr 07, 2011 at 04:31:59PM -0500, Adam Litke wrote: /* + * Disk Streaming + */ +typedef enum { +VIR_STREAM_DISK_ONE = 1, /* Stream a single disk unit */ +VIR_STREAM_DISK_START = 2, /* Stream the entire disk */ +VIR_STREAM_DISK_STOP = 4, /* Stop streaming a disk */

Re: [libvirt] [PATCH 1/6] Add new API virDomainStreamDisk[Info] to header and drivers

2011-04-08 Thread Stefan Hajnoczi
On Fri, Apr 8, 2011 at 2:31 PM, Daniel P. Berrange berra...@redhat.com wrote: I have CCed Anthony and Kevin. Anthony drove the QED image streaming and Kevin will probably be interested in the idea of allocating raw images as a background activity while QEMU runs.    /*     * @path: fully

Re: [libvirt] [PATCH 1/6] Add new API virDomainStreamDisk[Info] to header and drivers

2011-04-08 Thread Kevin Wolf
Am 08.04.2011 18:02, schrieb Stefan Hajnoczi: On Fri, Apr 8, 2011 at 2:31 PM, Daniel P. Berrange berra...@redhat.com wrote: I have CCed Anthony and Kevin. Anthony drove the QED image streaming and Kevin will probably be interested in the idea of allocating raw images as a background

Re: [libvirt] [PATCH 1/6] Add new API virDomainStreamDisk[Info] to header and drivers

2011-04-08 Thread Daniel P. Berrange
On Fri, Apr 08, 2011 at 06:35:16PM +0200, Kevin Wolf wrote: Am 08.04.2011 18:02, schrieb Stefan Hajnoczi: On Fri, Apr 8, 2011 at 2:31 PM, Daniel P. Berrange berra...@redhat.com wrote: I have CCed Anthony and Kevin. Anthony drove the QED image streaming and Kevin will probably be

Re: [libvirt] [PATCH 1/6] Add new API virDomainStreamDisk[Info] to header and drivers

2011-04-08 Thread Kevin Wolf
Am 08.04.2011 18:48, schrieb Daniel P. Berrange: On Fri, Apr 08, 2011 at 06:35:16PM +0200, Kevin Wolf wrote: Am 08.04.2011 18:02, schrieb Stefan Hajnoczi: On Fri, Apr 8, 2011 at 2:31 PM, Daniel P. Berrange berra...@redhat.com wrote: I have CCed Anthony and Kevin. Anthony drove the QED

Re: [libvirt] [PATCH 1/6] Add new API virDomainStreamDisk[Info] to header and drivers

2011-04-08 Thread Eric Blake
On 04/08/2011 07:31 AM, Daniel P. Berrange wrote: On Thu, Apr 07, 2011 at 04:31:59PM -0500, Adam Litke wrote: /* + * Disk Streaming + */ +typedef enum { +VIR_STREAM_DISK_ONE = 1, /* Stream a single disk unit */ +VIR_STREAM_DISK_START = 2, /* Stream the entire disk */ +

Re: [libvirt] [PATCH 1/6] Add new API virDomainStreamDisk[Info] to header and drivers

2011-04-08 Thread Adam Litke
On Fri, 2011-04-08 at 11:13 -0600, Eric Blake wrote: On 04/08/2011 07:31 AM, Daniel P. Berrange wrote: On Thu, Apr 07, 2011 at 04:31:59PM -0500, Adam Litke wrote: /* + * Disk Streaming + */ +typedef enum { +VIR_STREAM_DISK_ONE = 1, /* Stream a single disk unit */ +

Re: [libvirt] [PATCH 1/6] Add new API virDomainStreamDisk[Info] to header and drivers

2011-04-08 Thread Daniel P. Berrange
On Fri, Apr 08, 2011 at 12:44:26PM -0500, Adam Litke wrote: On Fri, 2011-04-08 at 11:13 -0600, Eric Blake wrote: On 04/08/2011 07:31 AM, Daniel P. Berrange wrote: On Thu, Apr 07, 2011 at 04:31:59PM -0500, Adam Litke wrote: /* + * Disk Streaming + */ +typedef enum { +

Re: [libvirt] [PATCH 1/6] Add new API virDomainStreamDisk[Info] to header and drivers

2011-04-08 Thread Anthony Liguori
On 04/08/2011 11:02 AM, Stefan Hajnoczi wrote: On Fri, Apr 8, 2011 at 2:31 PM, Daniel P. Berrangeberra...@redhat.com wrote: I have CCed Anthony and Kevin. Anthony drove the QED image streaming and Kevin will probably be interested in the idea of allocating raw images as a background activity

[libvirt] [PATCH 1/6] Add new API virDomainStreamDisk[Info] to header and drivers

2011-04-07 Thread Adam Litke
Set up the types for the disk streaming functions and insert it into the virDriver structure definition. Because of static initializers, update every driver and set the new field to NULL. * include/libvirt/libvirt.h.in: new API * src/driver.h src/*/*_driver.c src/vbox/vbox_tmpl.c: add the new

[libvirt] [PATCH 1/6] Add new API virDomainStreamDisk[Info] to header and drivers

2010-11-17 Thread Adam Litke
Set up the types for the disk streaming functions and insert it into the virDriver structure definition. Because of static initializers, update every driver and set the new field to NULL. * include/libvirt/libvirt.h.in: new API * src/driver.h src/*/*_driver.c src/vbox/vbox_tmpl.c: add the new