Re: [libvirt] [PATCH 1/6] Ensure consistent enablement of gcc 'diagnostic' pragma

2013-05-14 Thread Paul Eggert
On 05/13/13 12:16, Eric Blake wrote: I wonder if gnulib should use something similar, for the places where it uses pragma gcc push. I hope not. The only place gnulib does a push, is to turn off bogus diagnostics that I hope clang doesn't generate. If I'm wrong I suppose we can add an ||

[libvirt] [PATCH 1/6] Ensure consistent enablement of gcc 'diagnostic' pragma

2013-05-13 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The virt-compile-warnings.m4 file would do an explicit check for whether the compile could use the 'diagnostic' pragma push/pop feature. The src/internal.h file would then only enable it for GCC = 4.6 This breaks with clang which supports the pragma

Re: [libvirt] [PATCH 1/6] Ensure consistent enablement of gcc 'diagnostic' pragma

2013-05-13 Thread Eric Blake
[adding bug-gnulib] On 05/13/2013 06:17 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The virt-compile-warnings.m4 file would do an explicit check for whether the compile could use the 'diagnostic' pragma push/pop feature. The src/internal.h file would then