Re: [libvirt] [PATCH 1/6] conf: Introduce virStoragePoolDefFormatBuf

2015-04-03 Thread Erik Skultety
ACK with one nit: diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index b070448..a8e9876 100644 --- a/src/conf/storage_conf.c +++ b/src/conf/storage_conf.c @@ -1150,76 +1150,90 @@ virStoragePoolSourceFormat(virBufferPtr buf, --- 8 --- -virBufferAdjustIndent(buf,

Re: [libvirt] [PATCH 1/6] conf: Introduce virStoragePoolDefFormatBuf

2015-04-03 Thread Ján Tomko
On Thu, Apr 02, 2015 at 12:10:35PM +0200, Erik Skultety wrote: When modifying config/status XML, it might be handy to include some additional XML elements (e.g. poolstatus). In order to do so, introduce new formatting function virStoragePoolDefFormatBuf and make virStoragePoolDefFormat call

[libvirt] [PATCH 1/6] conf: Introduce virStoragePoolDefFormatBuf

2015-04-02 Thread Erik Skultety
When modifying config/status XML, it might be handy to include some additional XML elements (e.g. poolstatus). In order to do so, introduce new formatting function virStoragePoolDefFormatBuf and make virStoragePoolDefFormat call it. --- src/conf/storage_conf.c | 78