Re: [libvirt] [PATCH 1/7] Change calling conventions in remote driver client internals

2010-08-20 Thread Daniel P. Berrange
On Thu, Aug 19, 2010 at 01:50:43PM -0600, Eric Blake wrote: On 08/17/2010 11:02 AM, Daniel P. Berrange wrote: The remoteIO() method has wierd calling conventions, where it is passed a pre-allocated 'struct remote_call *' but then free()s it itself, instead of letting the caller free().

Re: [libvirt] [PATCH 1/7] Change calling conventions in remote driver client internals

2010-08-19 Thread Eric Blake
On 08/17/2010 11:02 AM, Daniel P. Berrange wrote: The remoteIO() method has wierd calling conventions, where it is passed a pre-allocated 'struct remote_call *' but then free()s it itself, instead of letting the caller free(). This fixes those wierd semantics s/wierd/weird/g *

[libvirt] [PATCH 1/7] Change calling conventions in remote driver client internals

2010-08-17 Thread Daniel P. Berrange
The remoteIO() method has wierd calling conventions, where it is passed a pre-allocated 'struct remote_call *' but then free()s it itself, instead of letting the caller free(). This fixes those wierd semantics * src/remote/remote_driver.c: Santize semantics of remoteIO method wrt to memory