[libvirt] [PATCH 1/7] datatypes: avoid redundant __FUNCTION__

2011-01-14 Thread Eric Blake
virLibConnError already includes __FUNCTION__ in its output, so we were redundant. Furthermore, clang warns that __FUNCTION__ is not a string literal (at least __FUNCTION__ will never contain %, so it was not a security risk). * src/datatypes.c: Replace __FUNCTION__ with a descriptive string.

Re: [libvirt] [PATCH 1/7] datatypes: avoid redundant __FUNCTION__

2011-01-14 Thread Matthias Bolte
2011/1/14 Eric Blake ebl...@redhat.com: virLibConnError already includes __FUNCTION__ in its output, so we were redundant.  Furthermore, clang warns that __FUNCTION__ is not a string literal (at least __FUNCTION__ will never contain %, so it was not a security risk). @@ -344,8 +344,16 @@

Re: [libvirt] [PATCH 1/7] datatypes: avoid redundant __FUNCTION__

2011-01-14 Thread Eric Blake
On 01/14/2011 02:45 PM, Matthias Bolte wrote: 2011/1/14 Eric Blake ebl...@redhat.com: virLibConnError already includes __FUNCTION__ in its output, so we were redundant. Furthermore, clang warns that __FUNCTION__ is not a string literal (at least __FUNCTION__ will never contain %, so it was