Re: [libvirt] [PATCH 1/7] hostdev: Add reattachPCIDevices()

2016-01-22 Thread Andrea Bolognani
On Fri, 2016-01-22 at 15:00 +, Daniel P. Berrange wrote: >  > IMHO you should leave virHostdevReattachPCIDevice alone, and just make > this new method call that one. In later patches you are calling this > reattachPCIDevices() method with a single device, forcing you to put > it into a

Re: [libvirt] [PATCH 1/7] hostdev: Add reattachPCIDevices()

2016-01-22 Thread Daniel P. Berrange
On Fri, Jan 22, 2016 at 05:39:33PM +0100, Andrea Bolognani wrote: > On Fri, 2016-01-22 at 15:00 +, Daniel P. Berrange wrote: > >  > > IMHO you should leave virHostdevReattachPCIDevice alone, and just make > > this new method call that one. In later patches you are calling this > >

Re: [libvirt] [PATCH 1/7] hostdev: Add reattachPCIDevices()

2016-01-22 Thread Daniel P. Berrange
On Tue, Jan 19, 2016 at 04:36:03PM +0100, Andrea Bolognani wrote: > This function replaces virHostdevReattachPCIDevice() and handles several > PCI devices instead of requiring to be called once for every device. > > The handling of active and inactive devices is updated and made more > explicit,

[libvirt] [PATCH 1/7] hostdev: Add reattachPCIDevices()

2016-01-19 Thread Andrea Bolognani
This function replaces virHostdevReattachPCIDevice() and handles several PCI devices instead of requiring to be called once for every device. The handling of active and inactive devices is updated and made more explicit, which means virHostdevReAttachPCIDevices() has to be updated as well. ---