Re: [libvirt] [PATCH 1/7] util: Fix regression of wwn reading

2013-05-08 Thread John Ferlan
On 05/06/2013 08:45 AM, Osier Yang wrote: Introduced by commit 244ce462e29, which refactored the helper for wwn reading, however, it forgot to change the old strndup and sizeof(buf), sizeof(buf) operates on the fixed length array (buf) in the old code, but now buf is a pointer. Before the

Re: [libvirt] [PATCH 1/7] util: Fix regression of wwn reading

2013-05-08 Thread Osier Yang
On 08/05/13 20:56, John Ferlan wrote: On 05/06/2013 08:45 AM, Osier Yang wrote: Introduced by commit 244ce462e29, which refactored the helper for wwn reading, however, it forgot to change the old strndup and sizeof(buf), sizeof(buf) operates on the fixed length array (buf) in the old code, but

Re: [libvirt] [PATCH 1/7] util: Fix regression of wwn reading

2013-05-08 Thread Doug Goldstein
On Wed, May 8, 2013 at 9:49 AM, Osier Yang jy...@redhat.com wrote: On 08/05/13 20:56, John Ferlan wrote: On 05/06/2013 08:45 AM, Osier Yang wrote: Introduced by commit 244ce462e29, which refactored the helper for wwn reading, however, it forgot to change the old strndup and sizeof(buf),

Re: [libvirt] [PATCH 1/7] util: Fix regression of wwn reading

2013-05-08 Thread Osier Yang
On 08/05/13 22:56, Doug Goldstein wrote: On Wed, May 8, 2013 at 9:49 AM, Osier Yang jy...@redhat.com mailto:jy...@redhat.com wrote: On 08/05/13 20:56, John Ferlan wrote: On 05/06/2013 08:45 AM, Osier Yang wrote: Introduced by commit 244ce462e29, which refactored the

Re: [libvirt] [PATCH 1/7] util: Fix regression of wwn reading

2013-05-08 Thread Eric Blake
On 05/06/2013 06:45 AM, Osier Yang wrote: Introduced by commit 244ce462e29, which refactored the helper for wwn reading, however, it forgot to change the old strndup and sizeof(buf), sizeof(buf) operates on the fixed length array (buf) in the old code, but now buf is a pointer. +++

[libvirt] [PATCH 1/7] util: Fix regression of wwn reading

2013-05-06 Thread Osier Yang
Introduced by commit 244ce462e29, which refactored the helper for wwn reading, however, it forgot to change the old strndup and sizeof(buf), sizeof(buf) operates on the fixed length array (buf) in the old code, but now buf is a pointer. Before the fix: % virsh nodedev-dumpxml scsi_host5 device