Re: [libvirt] [PATCH 1/7] util: buffer: Remove struct member munging

2019-04-01 Thread Laine Stump
On 4/1/19 2:54 AM, Peter Krempa wrote: On Fri, Mar 29, 2019 at 18:44:04 -0400, Laine Stump wrote: On 3/29/19 9:33 AM, Peter Krempa wrote: This was meant to stop abusing the members directly, but we don't do this for other internal structs. Additionally this did not stop the test from touching

Re: [libvirt] [PATCH 1/7] util: buffer: Remove struct member munging

2019-04-01 Thread Peter Krempa
On Fri, Mar 29, 2019 at 18:44:04 -0400, Laine Stump wrote: > On 3/29/19 9:33 AM, Peter Krempa wrote: > > This was meant to stop abusing the members directly, but we don't do > > this for other internal structs. Additionally this did not stop the > > test from touching the members. Remove the

Re: [libvirt] [PATCH 1/7] util: buffer: Remove struct member munging

2019-03-29 Thread Laine Stump
On 3/29/19 9:33 AM, Peter Krempa wrote: This was meant to stop abusing the members directly, but we don't do this for other internal structs. Additionally this did not stop the test from touching the members. Remove the header obscurization. I agree with you that this obfuscation does nothing

[libvirt] [PATCH 1/7] util: buffer: Remove struct member munging

2019-03-29 Thread Peter Krempa
This was meant to stop abusing the members directly, but we don't do this for other internal structs. Additionally this did not stop the test from touching the members. Remove the header obscurization. Signed-off-by: Peter Krempa --- src/util/virbuffer.c | 12 src/util/virbuffer.h