Re: [libvirt] [PATCH 1/8] snapshots: Avoid term 'checkpoint' for full system snapshot

2018-07-26 Thread Eric Blake
On 06/26/2018 08:27 PM, Eric Blake wrote: Lets try to see an example: T1 - user create new vm marked for incremental backup - system create base volume (S1) - system create new dirty bitmap (B1) Why do you need a dirty bitmap on a brand new system?  By definition, if the VM is brand new,

Re: [libvirt] [PATCH 1/8] snapshots: Avoid term 'checkpoint' for full system snapshot

2018-06-26 Thread Eric Blake
On 06/26/2018 10:56 AM, Nir Soffer wrote: On Wed, Jun 13, 2018 at 7:42 PM Eric Blake wrote: Upcoming patches plan to introduce virDomainCheckpointPtr as a new object for use in incremental backups, along with documentation how incremental backups differ from snapshots. But first, we need to

Re: [libvirt] [PATCH 1/8] snapshots: Avoid term 'checkpoint' for full system snapshot

2018-06-26 Thread Nir Soffer
On Wed, Jun 13, 2018 at 7:42 PM Eric Blake wrote: > Upcoming patches plan to introduce virDomainCheckpointPtr as a new > object for use in incremental backups, along with documentation > how incremental backups differ from snapshots. But first, we need > to rename any existing mention of a

Re: [libvirt] [PATCH 1/8] snapshots: Avoid term 'checkpoint' for full system snapshot

2018-06-26 Thread John Ferlan
On 06/25/2018 06:27 PM, Eric Blake wrote: > On 06/22/2018 04:16 PM, John Ferlan wrote: >> >> >> On 06/13/2018 12:42 PM, Eric Blake wrote: >>> Upcoming patches plan to introduce virDomainCheckpointPtr as a new >>> object for use in incremental backups, along with documentation >>> how incremental

Re: [libvirt] [PATCH 1/8] snapshots: Avoid term 'checkpoint' for full system snapshot

2018-06-25 Thread Eric Blake
On 06/22/2018 04:16 PM, John Ferlan wrote: On 06/13/2018 12:42 PM, Eric Blake wrote: Upcoming patches plan to introduce virDomainCheckpointPtr as a new object for use in incremental backups, along with documentation how incremental backups differ from snapshots. But first, we need to rename

Re: [libvirt] [PATCH 1/8] snapshots: Avoid term 'checkpoint' for full system snapshot

2018-06-22 Thread John Ferlan
On 06/13/2018 12:42 PM, Eric Blake wrote: > Upcoming patches plan to introduce virDomainCheckpointPtr as a new > object for use in incremental backups, along with documentation > how incremental backups differ from snapshots. But first, we need > to rename any existing mention of a 'system

[libvirt] [PATCH 1/8] snapshots: Avoid term 'checkpoint' for full system snapshot

2018-06-13 Thread Eric Blake
Upcoming patches plan to introduce virDomainCheckpointPtr as a new object for use in incremental backups, along with documentation how incremental backups differ from snapshots. But first, we need to rename any existing mention of a 'system checkpoint' to instead be a 'full system state