Re: [libvirt] [PATCH 1 of 5] Split out version script into multiple files

2009-01-05 Thread Jim Meyering
Daniel P. Berrange berra...@redhat.com wrote: On Tue, Dec 23, 2008 at 06:31:14PM +0100, Jim Meyering wrote: John Levon john.le...@sun.com wrote: On Tue, Dec 23, 2008 at 12:57:19PM +0100, Jim Meyering wrote: This all looks fine, but I'd prefer to retain the WARNING in the generated file,

Re: [libvirt] [PATCH 1 of 5] Split out version script into multiple files

2009-01-05 Thread Daniel P. Berrange
On Tue, Dec 23, 2008 at 06:31:14PM +0100, Jim Meyering wrote: John Levon john.le...@sun.com wrote: On Tue, Dec 23, 2008 at 12:57:19PM +0100, Jim Meyering wrote: This all looks fine, but I'd prefer to retain the WARNING in the generated file, so that people are less likely to modify it

Re: [libvirt] [PATCH 1 of 5] Split out version script into multiple files

2009-01-04 Thread Jim Meyering
Jim Meyering j...@meyering.net wrote: John Levon john.le...@sun.com wrote: On Tue, Dec 23, 2008 at 12:57:19PM +0100, Jim Meyering wrote: This all looks fine, but I'd prefer to retain the WARNING in the generated file, so that people are less likely to modify it directly. Along the Sure,

Re: [libvirt] [PATCH 1 of 5] Split out version script into multiple files

2008-12-23 Thread Jim Meyering
john.le...@sun.com wrote: # HG changeset patch # User john.le...@sun.com # Date 1230005985 28800 # Node ID 9621540df10095ea8b0cdc83cdd3d17a68509a64 # Parent 60090fd4e447795742265241b39f2759d9530514 Split out version script into multiple files ... diff --git a/src/Makefile.am

Re: [libvirt] [PATCH 1 of 5] Split out version script into multiple files

2008-12-23 Thread John Levon
On Tue, Dec 23, 2008 at 12:57:19PM +0100, Jim Meyering wrote: This all looks fine, but I'd prefer to retain the WARNING in the generated file, so that people are less likely to modify it directly. Along the Sure, your changes sound fine - are you going to commit your version? thanks john --

Re: [libvirt] [PATCH 1 of 5] Split out version script into multiple files

2008-12-23 Thread Jim Meyering
John Levon john.le...@sun.com wrote: On Tue, Dec 23, 2008 at 12:57:19PM +0100, Jim Meyering wrote: This all looks fine, but I'd prefer to retain the WARNING in the generated file, so that people are less likely to modify it directly. Along the Sure, your changes sound fine - are you going

[libvirt] [PATCH 1 of 5] Split out version script into multiple files

2008-12-22 Thread john . levon
# HG changeset patch # User john.le...@sun.com # Date 1230005985 28800 # Node ID 9621540df10095ea8b0cdc83cdd3d17a68509a64 # Parent 60090fd4e447795742265241b39f2759d9530514 Split out version script into multiple files Some (private) symbols disappear depending on build options. Introduce