Re: [libvirt] [PATCH 10/10] Replace sscanf in PCI device address parsing

2010-03-31 Thread Eric Blake
On 03/30/2010 10:20 AM, Matthias Bolte wrote: This also fixes a problem with MinGW's GCC on Windows. GCC complained bout the L modifier being unknown. s/bout/about/ --- src/util/pci.c | 59 +++ 1 files changed, 46 insertions(+), 13

Re: [libvirt] [PATCH 10/10] Replace sscanf in PCI device address parsing

2010-03-31 Thread Eric Blake
On 03/31/2010 10:38 AM, Eric Blake wrote: Hmm, thinking aloud here: your patch series has introduced several instances of checking STRPREFIX, then advancing to the end of the prefix. Maybe it's time to introduce a helper macro that does both the check and advances the pointer to the end of

Re: [libvirt] [PATCH 10/10] Replace sscanf in PCI device address parsing

2010-03-31 Thread Matthias Bolte
2010/3/31 Eric Blake ebl...@redhat.com: On 03/30/2010 10:20 AM, Matthias Bolte wrote: This also fixes a problem with MinGW's GCC on Windows. GCC complained bout the L modifier being unknown.              VIR_WARN(Unusual entry in PCI_SYSFS devices: %s, entry-d_name);              

Re: [libvirt] [PATCH 10/10] Replace sscanf in PCI device address parsing

2010-03-31 Thread Daniel P. Berrange
On Wed, Mar 31, 2010 at 10:48:47AM -0600, Eric Blake wrote: On 03/31/2010 10:38 AM, Eric Blake wrote: Hmm, thinking aloud here: your patch series has introduced several instances of checking STRPREFIX, then advancing to the end of the prefix. Maybe it's time to introduce a helper macro

Re: [libvirt] [PATCH 10/10] Replace sscanf in PCI device address parsing

2010-03-31 Thread Matthias Bolte
2010/3/31 Eric Blake ebl...@redhat.com: On 03/31/2010 10:38 AM, Eric Blake wrote: Hmm, thinking aloud here: your patch series has introduced several instances of checking STRPREFIX, then advancing to the end of the prefix.  Maybe it's time to introduce a helper macro that does both the check

[libvirt] [PATCH 10/10] Replace sscanf in PCI device address parsing

2010-03-30 Thread Matthias Bolte
This also fixes a problem with MinGW's GCC on Windows. GCC complained bout the L modifier being unknown. --- src/util/pci.c | 59 +++ 1 files changed, 46 insertions(+), 13 deletions(-) diff --git a/src/util/pci.c b/src/util/pci.c index