Re: [libvirt] [PATCH 10/10] docs: Describe the dhcp 'enable' and 'relay' attributes

2013-02-28 Thread Daniel Veillard
On Wed, Feb 27, 2013 at 09:38:33PM -0700, Eric Blake wrote: On 02/27/2013 09:29 PM, TJ wrote: [...] And a big THANK YOU for contributing to the community. Too often, I forget to express gratitude for new contributors braving the unknown waters of posting to a list where they are not sure of

[libvirt] [PATCH 10/10] docs: Describe the dhcp 'enable' and 'relay' attributes

2013-02-27 Thread TJ
From: TJ li...@iam.tj Signed-off-by: TJ li...@iam.tj --- docs/formatnetwork.html.in | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/docs/formatnetwork.html.in b/docs/formatnetwork.html.in index 41a83fa..c4c4def 100644 --- a/docs/formatnetwork.html.in

Re: [libvirt] [PATCH 10/10] docs: Describe the dhcp 'enable' and 'relay' attributes

2013-02-27 Thread Eric Blake
On 02/27/2013 07:57 PM, TJ wrote: From: TJ li...@iam.tj Signed-off-by: TJ li...@iam.tj --- docs/formatnetwork.html.in | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/docs/formatnetwork.html.in b/docs/formatnetwork.html.in index 41a83fa..c4c4def

Re: [libvirt] [PATCH 10/10] docs: Describe the dhcp 'enable' and 'relay' attributes

2013-02-27 Thread TJ
On 28/02/13 04:16, Eric Blake wrote: diff --git a/docs/formatnetwork.html.in b/docs/formatnetwork.html.in index 41a83fa..c4c4def 100644 --- a/docs/formatnetwork.html.in +++ b/docs/formatnetwork.html.in Yay - your series added documentation! I commented to a student that the documentation

Re: [libvirt] [PATCH 10/10] docs: Describe the dhcp 'enable' and 'relay' attributes

2013-02-27 Thread Eric Blake
On 02/27/2013 09:29 PM, TJ wrote: But it didn't add any unit tests (a new .xml file somewhere under tests/networkxml2argvdata or networkxml2xml{in,out} to verify that we can round-trip the new XML and generate the expected command line), and it failed to add the RelaxNG grammar