Re: [libvirt] [PATCH 10/11] Improve SCSI volume key and name generation

2010-11-19 Thread Eric Blake
On 11/12/2010 09:22 AM, Daniel P. Berrange wrote: > The SCSI volumes currently get a name like '17:0:0:1' based > on $host:$bus:$target:$lun. The names are intended to be unique > per pool and stable across pool restarts. The inclusion of the > $host component breaks this, because the $host number

Re: [libvirt] [PATCH 10/11] Improve SCSI volume key and name generation

2010-11-12 Thread Dave Allan
On Fri, Nov 12, 2010 at 06:43:39PM +, Daniel P. Berrange wrote: > On Fri, Nov 12, 2010 at 12:37:41PM -0500, Dave Allan wrote: > > On Fri, Nov 12, 2010 at 04:22:43PM +, Daniel P. Berrange wrote: > > > The SCSI volumes currently get a name like '17:0:0:1' based > > > on $host:$bus:$target:$lu

Re: [libvirt] [PATCH 10/11] Improve SCSI volume key and name generation

2010-11-12 Thread Daniel P. Berrange
On Fri, Nov 12, 2010 at 08:06:32PM +0100, Paolo Bonzini wrote: > On 11/12/2010 07:45 PM, Daniel P. Berrange wrote: > >On Fri, Nov 12, 2010 at 07:32:05PM +0100, Paolo Bonzini wrote: > >>On 11/12/2010 05:22 PM, Daniel P. Berrange wrote: > >>>+{ > >>>+const char *cmdargv[] = { > >>>+"/lib/

Re: [libvirt] [PATCH 10/11] Improve SCSI volume key and name generation

2010-11-12 Thread Paolo Bonzini
On 11/12/2010 07:45 PM, Daniel P. Berrange wrote: On Fri, Nov 12, 2010 at 07:32:05PM +0100, Paolo Bonzini wrote: On 11/12/2010 05:22 PM, Daniel P. Berrange wrote: +{ +const char *cmdargv[] = { +"/lib/udev/scsi_id", +"--replace-whitespace", +"--whitelisted", +

Re: [libvirt] [PATCH 10/11] Improve SCSI volume key and name generation

2010-11-12 Thread Daniel P. Berrange
On Fri, Nov 12, 2010 at 12:37:41PM -0500, Dave Allan wrote: > On Fri, Nov 12, 2010 at 04:22:43PM +, Daniel P. Berrange wrote: > > > The SCSI volumes also get a 'key' field based on the fully > > qualified volume path. All SCSI volumes have a unique serial > > available in hardware which can be

Re: [libvirt] [PATCH 10/11] Improve SCSI volume key and name generation

2010-11-12 Thread Daniel P. Berrange
On Fri, Nov 12, 2010 at 07:32:05PM +0100, Paolo Bonzini wrote: > On 11/12/2010 05:22 PM, Daniel P. Berrange wrote: > >+{ > >+const char *cmdargv[] = { > >+"/lib/udev/scsi_id", > >+"--replace-whitespace", > >+"--whitelisted", > >+"--device", dev, > >+NULL

Re: [libvirt] [PATCH 10/11] Improve SCSI volume key and name generation

2010-11-12 Thread Daniel P. Berrange
On Fri, Nov 12, 2010 at 12:37:41PM -0500, Dave Allan wrote: > On Fri, Nov 12, 2010 at 04:22:43PM +, Daniel P. Berrange wrote: > > The SCSI volumes currently get a name like '17:0:0:1' based > > on $host:$bus:$target:$lun. The names are intended to be unique > > per pool and stable across pool r

Re: [libvirt] [PATCH 10/11] Improve SCSI volume key and name generation

2010-11-12 Thread Paolo Bonzini
On 11/12/2010 05:22 PM, Daniel P. Berrange wrote: +{ +const char *cmdargv[] = { +"/lib/udev/scsi_id", +"--replace-whitespace", +"--whitelisted", +"--device", dev, +NULL +}; Does this needs to be "/lib/udev/scsi_id -gud " for RHEL5 compatibility?

Re: [libvirt] [PATCH 10/11] Improve SCSI volume key and name generation

2010-11-12 Thread Dave Allan
On Fri, Nov 12, 2010 at 04:22:43PM +, Daniel P. Berrange wrote: > The SCSI volumes currently get a name like '17:0:0:1' based > on $host:$bus:$target:$lun. The names are intended to be unique > per pool and stable across pool restarts. The inclusion of the > $host component breaks this, because

[libvirt] [PATCH 10/11] Improve SCSI volume key and name generation

2010-11-12 Thread Daniel P. Berrange
The SCSI volumes currently get a name like '17:0:0:1' based on $host:$bus:$target:$lun. The names are intended to be unique per pool and stable across pool restarts. The inclusion of the $host component breaks this, because the $host number for iSCSI pools is dynamically allocated by the kernel at