Re: [libvirt] [PATCH 10/15] qemu: Error out when domain starting if the cdbfilter setting conflicts

2012-12-07 Thread Daniel P. Berrange
On Fri, Dec 07, 2012 at 12:16:08PM +0800, Osier Yang wrote: On 2012年12月07日 09:00, Eric Blake wrote: On 12/05/2012 04:14 AM, Osier Yang wrote: On 2012年12月05日 19:03, Jiri Denemark wrote: On Wed, Dec 05, 2012 at 18:54:42 +0800, Osier Yang wrote: ... However, the mainly reason I choosed to use a

Re: [libvirt] [PATCH 10/15] qemu: Error out when domain starting if the cdbfilter setting conflicts

2012-12-06 Thread Eric Blake
On 12/05/2012 04:14 AM, Osier Yang wrote: On 2012年12月05日 19:03, Jiri Denemark wrote: On Wed, Dec 05, 2012 at 18:54:42 +0800, Osier Yang wrote: ... However, the mainly reason I choosed to use a sub-list of domain names is for future extenstion, I.E. Assuming there are other disk setting (you

Re: [libvirt] [PATCH 10/15] qemu: Error out when domain starting if the cdbfilter setting conflicts

2012-12-06 Thread Osier Yang
On 2012年12月07日 09:00, Eric Blake wrote: On 12/05/2012 04:14 AM, Osier Yang wrote: On 2012年12月05日 19:03, Jiri Denemark wrote: On Wed, Dec 05, 2012 at 18:54:42 +0800, Osier Yang wrote: ... However, the mainly reason I choosed to use a sub-list of domain names is for future extenstion, I.E.

[libvirt] [PATCH 10/15] qemu: Error out when domain starting if the cdbfilter setting conflicts

2012-12-05 Thread Osier Yang
This prevents the domain starting if the shared disk's setting conflicts with other active domain(s), E.g. A domain with cdbfilter set as yes, however, another active domain is using it set as no. * src/conf/domain_conf.h: (Declare helper virDomainDiskFindByPath) * src/conf/domain_conf.c:

[libvirt] [PATCH 10/15] qemu: Error out when domain starting if the cdbfilter setting conflicts

2012-12-05 Thread Osier Yang
This prevents the domain starting if the shared disk's setting conflicts with other active domain(s), E.g. A domain with cdbfilter set as yes, however, another active domain is using it set as no. * src/conf/domain_conf.h: (Declare helper virDomainDiskFindByPath) * src/conf/domain_conf.c:

Re: [libvirt] [PATCH 10/15] qemu: Error out when domain starting if the cdbfilter setting conflicts

2012-12-05 Thread Jiri Denemark
On Wed, Dec 05, 2012 at 17:25:11 +0800, Osier Yang wrote: This prevents the domain starting if the shared disk's setting conflicts with other active domain(s), E.g. A domain with cdbfilter set as yes, however, another active domain is using it set as no. ... diff --git

Re: [libvirt] [PATCH 10/15] qemu: Error out when domain starting if the cdbfilter setting conflicts

2012-12-05 Thread Osier Yang
On 2012年12月05日 18:20, Jiri Denemark wrote: On Wed, Dec 05, 2012 at 17:25:11 +0800, Osier Yang wrote: This prevents the domain starting if the shared disk's setting conflicts with other active domain(s), E.g. A domain with cdbfilter set as yes, however, another active domain is using it set as

Re: [libvirt] [PATCH 10/15] qemu: Error out when domain starting if the cdbfilter setting conflicts

2012-12-05 Thread Osier Yang
On 2012年12月05日 18:50, Osier Yang wrote: On 2012年12月05日 18:20, Jiri Denemark wrote: On Wed, Dec 05, 2012 at 17:25:11 +0800, Osier Yang wrote: This prevents the domain starting if the shared disk's setting conflicts with other active domain(s), E.g. A domain with cdbfilter set as yes, however,

Re: [libvirt] [PATCH 10/15] qemu: Error out when domain starting if the cdbfilter setting conflicts

2012-12-05 Thread Jiri Denemark
On Wed, Dec 05, 2012 at 18:54:42 +0800, Osier Yang wrote: ... However, the mainly reason I choosed to use a sub-list of domain names is for future extenstion, I.E. Assuming there are other disk setting (you never known how many they will be), we have to guarantee they are same among guests

Re: [libvirt] [PATCH 10/15] qemu: Error out when domain starting if the cdbfilter setting conflicts

2012-12-05 Thread Osier Yang
On 2012年12月05日 19:03, Jiri Denemark wrote: On Wed, Dec 05, 2012 at 18:54:42 +0800, Osier Yang wrote: ... However, the mainly reason I choosed to use a sub-list of domain names is for future extenstion, I.E. Assuming there are other disk setting (you never known how many they will be), we have