Re: [libvirt] [PATCH 10/18] tpm: Move qemuTPMEmulatorInit to virTPMEmulatorInit in virtpm.c

2019-07-10 Thread Stefan Berger
On 7/9/19 4:24 PM, Marc-André Lureau wrote: On Tue, Jul 9, 2019 at 9:24 PM Stefan Berger wrote: Move qemuTPMEmulatorInit to virTPMEmulatorInit in virtpm.c and introduce a few functions to query the executables needed for virCommands. Signed-off-by: Stefan Berger Couldn't there be a TOCTOU is

Re: [libvirt] [PATCH 10/18] tpm: Move qemuTPMEmulatorInit to virTPMEmulatorInit in virtpm.c

2019-07-09 Thread Marc-André Lureau
On Tue, Jul 9, 2019 at 9:24 PM Stefan Berger wrote: > > Move qemuTPMEmulatorInit to virTPMEmulatorInit in virtpm.c and introduce > a few functions to query the executables needed for virCommands. > > Signed-off-by: Stefan Berger Couldn't there be a TOCTOU issue? Anyway, for the move: Reviewed-b

[libvirt] [PATCH 10/18] tpm: Move qemuTPMEmulatorInit to virTPMEmulatorInit in virtpm.c

2019-07-09 Thread Stefan Berger
Move qemuTPMEmulatorInit to virTPMEmulatorInit in virtpm.c and introduce a few functions to query the executables needed for virCommands. Signed-off-by: Stefan Berger --- src/libvirt_private.syms | 4 ++ src/qemu/qemu_tpm.c | 83 src/tpm/virtpm.c