Re: [libvirt] [PATCH 10/21] Don't let parent of daemon exit until basic initialization is done

2009-11-02 Thread Daniel P. Berrange
On Mon, Nov 02, 2009 at 05:05:55PM -0500, Cole Robinson wrote: On 10/23/2009 09:05 AM, Daniel P. Berrange wrote: The daemonizing code lets the parent exit almost immediately. This means that it may think it has successfully started even when important failures occur like not being able to

Re: [libvirt] [PATCH 10/21] Don't let parent of daemon exit until basic initialization is done

2009-10-31 Thread Laurent Léonard
Hi, I'm not a C expert, but I see there is a use of an unitialized variable: default: { int got, exitstatus = 0; int ret; char status; close(statuspipe[1]); /* We wait to make sure the first child forked successfully */

Re: [libvirt] [PATCH 10/21] Don't let parent of daemon exit until basic initialization is done

2009-10-31 Thread Daniel P. Berrange
On Sat, Oct 31, 2009 at 02:29:42PM +0100, Laurent L?onard wrote: Hi, I'm not a C expert, but I see there is a use of an unitialized variable: default: { int got, exitstatus = 0; int ret; char status; close(statuspipe[1]);

Re: [libvirt] [PATCH 10/21] Don't let parent of daemon exit until basic initialization is done

2009-10-29 Thread Guido Günther
On Wed, Oct 28, 2009 at 06:52:49PM +, Daniel P. Berrange wrote: On Wed, Oct 28, 2009 at 03:22:38PM +0100, Guido G?nther wrote: Hi Daniel, On Fri, Oct 23, 2009 at 02:05:39PM +0100, Daniel P. Berrange wrote: The daemonizing code lets the parent exit almost immediately. This means that

Re: [libvirt] [PATCH 10/21] Don't let parent of daemon exit until basic initialization is done

2009-10-29 Thread Daniel Veillard
On Fri, Oct 23, 2009 at 02:05:39PM +0100, Daniel P. Berrange wrote: The daemonizing code lets the parent exit almost immediately. This means that it may think it has successfully started even when important failures occur like not being able to acquire the PID file. It also means network

Re: [libvirt] [PATCH 10/21] Don't let parent of daemon exit until basic initialization is done

2009-10-29 Thread Daniel P. Berrange
On Thu, Oct 29, 2009 at 04:19:47PM +0100, Daniel Veillard wrote: On Fri, Oct 23, 2009 at 02:05:39PM +0100, Daniel P. Berrange wrote: The daemonizing code lets the parent exit almost immediately. This means that it may think it has successfully started even when important failures occur like

Re: [libvirt] [PATCH 10/21] Don't let parent of daemon exit until basic initialization is done

2009-10-29 Thread Daniel Veillard
On Thu, Oct 29, 2009 at 03:29:38PM +, Daniel P. Berrange wrote: On Thu, Oct 29, 2009 at 04:19:47PM +0100, Daniel Veillard wrote: On Fri, Oct 23, 2009 at 02:05:39PM +0100, Daniel P. Berrange wrote: The daemonizing code lets the parent exit almost immediately. This means that it may

Re: [libvirt] [PATCH 10/21] Don't let parent of daemon exit until basic initialization is done

2009-10-28 Thread Guido Günther
Hi Daniel, On Fri, Oct 23, 2009 at 02:05:39PM +0100, Daniel P. Berrange wrote: The daemonizing code lets the parent exit almost immediately. This means that it may think it has successfully started even when important failures occur like not being able to acquire the PID file. It also means

Re: [libvirt] [PATCH 10/21] Don't let parent of daemon exit until basic initialization is done

2009-10-28 Thread Daniel P. Berrange
On Wed, Oct 28, 2009 at 03:22:38PM +0100, Guido G?nther wrote: Hi Daniel, On Fri, Oct 23, 2009 at 02:05:39PM +0100, Daniel P. Berrange wrote: The daemonizing code lets the parent exit almost immediately. This means that it may think it has successfully started even when important failures

[libvirt] [PATCH 10/21] Don't let parent of daemon exit until basic initialization is done

2009-10-23 Thread Daniel P. Berrange
The daemonizing code lets the parent exit almost immediately. This means that it may think it has successfully started even when important failures occur like not being able to acquire the PID file. It also means network sockets are not yet open. To address this when daemonizing the parent passes