Re: [libvirt] [PATCH 11/11] conf: Move and optimize disk target duplicity checking

2016-02-06 Thread Ján Tomko
On Thu, Feb 04, 2016 at 03:49:48PM +0100, Peter Krempa wrote: > Move the logic from virDomainDiskDefDstDuplicates into > virDomainDiskDefCheckDuplicateInfo so that we don't have to loop > multiple times through the array of disks. Since the original function > was called in qemuBuildDriveDevStr,

[libvirt] [PATCH 11/11] conf: Move and optimize disk target duplicity checking

2016-02-04 Thread Peter Krempa
Move the logic from virDomainDiskDefDstDuplicates into virDomainDiskDefCheckDuplicateInfo so that we don't have to loop multiple times through the array of disks. Since the original function was called in qemuBuildDriveDevStr, it was actually called for every single disk which was quite wasteful.