Re: [libvirt] [PATCH 11/12] tests: qemuxml2xml: make GIC handling optional

2019-04-10 Thread Andrea Bolognani
On Mon, 2019-04-01 at 12:47 -0400, Cole Robinson wrote: [...] > # define DO_TEST(name, ...) \ > -DO_TEST_FULL(name, WHEN_BOTH, GIC_NONE, __VA_ARGS__) > +DO_TEST_FULL(name, WHEN_BOTH, ARG_QEMU_CAPS, __VA_ARGS__, QEMU_CAPS_LAST) Please move ARG_QEMU_CAPS and its arguments to a separate line

[libvirt] [PATCH 11/12] tests: qemuxml2xml: make GIC handling optional

2019-04-01 Thread Cole Robinson
Make all users of GIC_X use ARG_GIC explicitly, and drop the required gic parameter from DO_TEST_FULL Signed-off-by: Cole Robinson --- tests/qemuxml2xmltest.c | 85 ++--- 1 file changed, 55 insertions(+), 30 deletions(-) diff --git a/tests/qemuxml2xmltest.c b