Re: [libvirt] [PATCH 11/25] qemu: Refactor helpers for USB device attachment

2013-05-13 Thread Osier Yang
On 07/05/13 20:23, John Ferlan wrote: On 05/03/2013 02:07 PM, Osier Yang wrote: It's better to put the usb related codes into qemuDomainAttachHostUsbDevice instead of qemuDomainAttachHostDevice. And in the old qemuDomainAttachHostDevice, just stealing the "usb" from driver->activeUsbHostdevs le

Re: [libvirt] [PATCH 11/25] qemu: Refactor helpers for USB device attachment

2013-05-07 Thread John Ferlan
On 05/03/2013 02:07 PM, Osier Yang wrote: > It's better to put the usb related codes into qemuDomainAttachHostUsbDevice > instead of qemuDomainAttachHostDevice. > > And in the old qemuDomainAttachHostDevice, just stealing the "usb" from > driver->activeUsbHostdevs leaks the memory. Seems this is

[libvirt] [PATCH 11/25] qemu: Refactor helpers for USB device attachment

2013-05-03 Thread Osier Yang
It's better to put the usb related codes into qemuDomainAttachHostUsbDevice instead of qemuDomainAttachHostDevice. And in the old qemuDomainAttachHostDevice, just stealing the "usb" from driver->activeUsbHostdevs leaks the memory. --- src/qemu/qemu_hotplug.c | 77 +